Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory #5921

Merged
merged 5 commits into from
Jan 15, 2024
Merged

fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory #5921

merged 5 commits into from
Jan 15, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 19, 2023

Description

This PR moves headers to a directory that matches the name of the package.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 19, 2023
@esteve esteve mentioned this pull request Dec 19, 2023
Open
16 tasks
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
@esteve esteve enabled auto-merge (squash) December 20, 2023 14:11
@esteve esteve force-pushed the autoware-auto-perception-rviz-plugin branch from 9f5a2f1 to e4f365c Compare December 22, 2023 11:46
@esteve esteve marked this pull request as draft January 8, 2024 12:12
auto-merge was automatically disabled January 8, 2024 12:12

Pull request was converted to draft

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39642d2) 14.65% compared to head (c59bd04) 14.63%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5921      +/-   ##
==========================================
- Coverage   14.65%   14.63%   -0.03%     
==========================================
  Files        1858     1862       +4     
  Lines      126455   126684     +229     
  Branches    37063    37063              
==========================================
  Hits        18535    18535              
- Misses      87097    87326     +229     
  Partials    20823    20823
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.65% <ø> (ø) Carriedforward from 39642d2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the autoware-auto-perception-rviz-plugin branch 2 times, most recently from 04fd988 to f9a0474 Compare January 9, 2024 12:06
@esteve esteve marked this pull request as ready for review January 9, 2024 12:06
@esteve esteve enabled auto-merge (squash) January 10, 2024 08:49
@esteve
Copy link
Contributor Author

esteve commented Jan 11, 2024

@scepter914 @taikitanaka3 @1222-takeshi @xmfcx @mitsudome-r could you have a look at these changes when you have a moment? Thanks.

miursh
miursh approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@esteve could you fix the conflicts?

@esteve esteve force-pushed the autoware-auto-perception-rviz-plugin branch from f9a0474 to c59bd04 Compare January 12, 2024 11:45
@esteve
Copy link
Contributor Author

esteve commented Jan 12, 2024

@miursh done, thanks for the review.

@esteve
Copy link
Contributor Author

esteve commented Jan 15, 2024

@miursh thanks for the review, unfortunately I can't merge this PR, not sure if it's because it needs a review from one of the code owners (@1222-takeshi @scepter914 @taikitanaka3). Can you merge it? Thanks

scepter914
scepter914 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit b60975f into main Jan 15, 2024
24 of 25 checks passed
@esteve esteve deleted the autoware-auto-perception-rviz-plugin branch January 15, 2024 10:09
@esteve
Copy link
Contributor Author

esteve commented Jan 15, 2024

@scepter914 thanks!

@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 24, 2024
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_perception_rviz_plugin): move headers to a separate…
5b95c9b 
… directory (autowarefoundation#5921)

* fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix include

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix header paths in CMakeLists.txt

Signed-off-by: Esteve Fernandez <[email protected]>

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_perception_rviz_plugin): move headers to a separate…
04bef8b 
… directory (autowarefoundation#5921)

* fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix include

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix header paths in CMakeLists.txt

Signed-off-by: Esteve Fernandez <[email protected]>

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_perception_rviz_plugin): move headers to a separate…
91df8d1 
… directory (autowarefoundation#5921)

* fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix include

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix header paths in CMakeLists.txt

Signed-off-by: Esteve Fernandez <[email protected]>

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@esteve @pre-commit-ci @karishma1911
fix(autoware_auto_perception_rviz_plugin): move headers to a separate…
425d38c 
… directory (autowarefoundation#5921)

* fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix include

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

* fix(autoware_auto_perception_rviz_plugin): fix header paths in CMakeLists.txt

Signed-off-by: Esteve Fernandez <[email protected]>

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miursh miursh miursh approved these changes

@scepter914 scepter914 scepter914 approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @scepter914 @miursh