Packages should put their headers directory in a directory named after the package

[esteve]

Checklist

• I've read the contribution guidelines.
• I've searched other issues and no duplicate issues were found.
• I'm convinced that this is not my fault but a bug.

Description

Following https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#include packages should put their headers in a separate directory named like the packagea

See https://github.com/orgs/autowarefoundation/discussions/4066

Expected behavior

All packages have their headers in a separate directory

Actual behavior

The following packages have their headers in directories other than a directory named like the package:

• autoware_auto_common fix(autoware_auto_common): move headers to a separate directory autoware.universe#5919
• autoware_auto_geometry fix(autoware_auto_geometry): move headers to a separate directory autoware.universe#5941
• autoware_auto_perception_rviz_plugin fix(autoware_auto_perception_rviz_plugin): move headers to a separate directory autoware.universe#5921
• detected_object_validation build(detected_object_validation): move header files to a separate directory to avoid conflicts autoware.universe#5851
• detection_by_tracker build(detection_by_tracker): move utils.hpp file to the detection_by_tracker folder and namespace to avoid conflicts autoware.universe#5837
• diagnostic_converter fix(diagnostic_converter): move headers to a separate directory autoware.universe#5943
• object_merger fix(object_merger): move headers to object_merger directory autoware.universe#5926
• planning_test_utils fix(planning_test_utils): rename header directory to match project name autoware.universe#5863
• probabilistic_occupancy_grid_map build(probabilistic_occupancy_grid_map): move header files to the probabilistic_occupancy_grid_map folder to avoid conflicts autoware.universe#5839
• radar_fusion_to_detected_object fix(radar_fusion_to_detected_object): move headers to a separate directory autoware.universe#5920
• system_monitor fix(system_monitor): move headers to a separate directory autoware.universe#5942
• tier4_planning_rviz_plugin fix(tier4_planning_rviz_plugin): move headers to tier4_planning_rviz_plugin directory autoware.universe#5927
• traffic_light_visualization fix(traffic_light_visualization): move header directory to match package name autoware.universe#5864

Steps to reproduce

Check the directory hierarchy

Versions

No response

Possible causes

No response

Additional context

No response

[mitsudome-r]

All tasks are finished, but we will close this after @esteve confirms that the build passes in https://github.com/autowarefoundation/autoware-deb-packages.

[esteve]

A followup to this ticket, we will rename headers directories either to autoware_PACKAGE_NAME or autoware/PACKAGE_NAME, see https://github.com/orgs/autowarefoundation/discussions/4097#discussioncomment-8380000 for context