-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_auto_geometry): move headers to a separate directory #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Dec 22, 2023
esteve
added
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
and removed
type:documentation
Creating or refining documentation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Dec 22, 2023
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
Dec 22, 2023
Signed-off-by: Esteve Fernandez <[email protected]>
16 tasks
Signed-off-by: Esteve Fernandez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5941 +/- ##
==========================================
+ Coverage 15.28% 15.59% +0.31%
==========================================
Files 1750 1762 +12
Lines 120432 121022 +590
Branches 36729 36950 +221
==========================================
+ Hits 18404 18877 +473
- Misses 81375 81398 +23
- Partials 20653 20747 +94
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
satoshi-ota
approved these changes
Dec 26, 2023
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…towarefoundation#5941) * fix(autoware_auto_geometry): move headers to a separate directory Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix header name Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix headers for CMake Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…towarefoundation#5941) * fix(autoware_auto_geometry): move headers to a separate directory Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix header name Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix headers for CMake Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…towarefoundation#5941) * fix(autoware_auto_geometry): move headers to a separate directory Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix header name Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix headers for CMake Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#5941) * fix(autoware_auto_geometry): move headers to a separate directory Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix header name Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix * fix: fix headers for CMake Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves headers to a directory that matches the name of the package.
See autowarefoundation/autoware#4070
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.