Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_monitor): move headers to a separate directory #5942

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 22, 2023

Description

This PR moves headers to a directory that matches the name of the package.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 22, 2023
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e2f184) 15.28% compared to head (a350191) 15.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5942      +/-   ##
==========================================
- Coverage   15.28%   15.27%   -0.01%     
==========================================
  Files        1750     1753       +3     
  Lines      120432   120465      +33     
  Branches    36729    36729              
==========================================
  Hits        18404    18404              
- Misses      81375    81408      +33     
  Partials    20653    20653              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.28% <ø> (ø) Carriedforward from 2e2f184

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve marked this pull request as ready for review December 22, 2023 14:47
@esteve esteve requested a review from ito-san as a code owner December 22, 2023 14:47
@esteve esteve enabled auto-merge (squash) December 22, 2023 14:48
Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve merged commit 9f656e3 into main Dec 25, 2023
23 of 24 checks passed
@esteve esteve deleted the system-monitor-move-headers branch December 25, 2023 05:15
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…undation#5942)

* fix(system_monitor): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…undation#5942)

* fix(system_monitor): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…undation#5942)

* fix(system_monitor): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…undation#5942)

* fix(system_monitor): move headers to a separate directory

Signed-off-by: Esteve Fernandez <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants