Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(autoware_auto_perception_rviz_plugin): add existence probability for rviz #5986

Merged
merged 6 commits into from
Jan 8, 2024
Merged

chore(autoware_auto_perception_rviz_plugin): add existence probability for rviz #5986

merged 6 commits into from
Jan 8, 2024

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Dec 28, 2023 •
edited
Loading

Description

This to add existence_probability for detected object rendering in rviz. The default status is disable.

Related link

TIER IV RELATED LINK

Tests performed

Confirm that Display Existence Probability namespace is added.

image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 28, 2023
@badai-nguyen
chore: typo
c1b1df3 
Signed-off-by: badai-nguyen <[email protected]>
@miursh miursh requested a review from kminoda December 28, 2023 00:51
@badai-nguyen badai-nguyen requested review from YoshiRi, miursh and TomohitoAndo and removed request for kminoda December 28, 2023 00:51
@badai-nguyen badai-nguyen marked this pull request as ready for review December 28, 2023 00:52
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 28, 2023
@kminoda kminoda self-requested a review December 28, 2023 00:52
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (f4ea429) 15.22% compared to head (515b355) 15.33%.

Files Patch % Lines
...gin/src/object_detection/object_polygon_detail.cpp 0.00% 11 Missing ⚠️
...src/object_detection/predicted_objects_display.cpp 0.00% 11 Missing ⚠️
.../src/object_detection/detected_objects_display.cpp 0.00% 8 Missing ⚠️
...n/src/object_detection/tracked_objects_display.cpp 0.00% 8 Missing ⚠️
...e/object_detection/object_polygon_display_base.hpp 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5986      +/-   ##
==========================================
+ Coverage   15.22%   15.33%   +0.11%     
==========================================
  Files        1751     1750       -1     
  Lines      120898   119781    -1117     
  Branches    36778    36226     -552     
==========================================
- Hits        18407    18371      -36     
+ Misses      81813    80805    -1008     
+ Partials    20678    20605      -73
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.34% <ø> (+0.11%) ⬆️ Carriedforward from f2c4536

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kminoda
kminoda reviewed Dec 28, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Let me review on behalf of @miursh

common/autoware_auto_perception_rviz_plugin/src/object_detection/detected_objects_display.cpp Outdated Show resolved Hide resolved
@badai-nguyen
chore: adjust text position
6706a0a 
Signed-off-by: badai-nguyen <[email protected]>
kminoda
kminoda approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (cc: @miursh )

miursh
miursh approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q]
@badai-nguyen Is this change only for detected_objects? not for tracked/predicted?

@badai-nguyen
Copy link
Contributor Author

[Q] @badai-nguyen Is this change only for detected_objects? not for tracked/predicted?

@miursh Yes. Currently only for detected_objects. Is better to add for tracked/predicted objects?

@badai-nguyen
Copy link
Contributor Author

[Q] @badai-nguyen Is this change only for detected_objects? not for tracked/predicted?

@miursh I added existence_probability rendering also for tracked/predicted at f2c4536
image

@miursh miursh merged commit aef79fe into autowarefoundation:main Jan 8, 2024
21 of 24 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jan 10, 2024
Merged
@badai-nguyen badai-nguyen deleted the chore/debug/add_existence_prob_for_rviz branch January 29, 2024 00:03
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@badai-nguyen @miursh @karishma1911
chore(autoware_auto_perception_rviz_plugin): add existence probabilit…
a84f3ce 
…y for rviz (autowarefoundation#5986)

* chore: add existence prob for rviz objects

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: adjust text position

Signed-off-by: badai-nguyen <[email protected]>

* fix: add existence prob for tracked and predicted objects

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@badai-nguyen @miursh @karishma1911
chore(autoware_auto_perception_rviz_plugin): add existence probabilit…
2c18513 
…y for rviz (autowarefoundation#5986)

* chore: add existence prob for rviz objects

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: adjust text position

Signed-off-by: badai-nguyen <[email protected]>

* fix: add existence prob for tracked and predicted objects

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@badai-nguyen @miursh @karishma1911
chore(autoware_auto_perception_rviz_plugin): add existence probabilit…
86109bf 
…y for rviz (autowarefoundation#5986)

* chore: add existence prob for rviz objects

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: adjust text position

Signed-off-by: badai-nguyen <[email protected]>

* fix: add existence prob for tracked and predicted objects

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@badai-nguyen @miursh @karishma1911
chore(autoware_auto_perception_rviz_plugin): add existence probabilit…
2182cc2 
…y for rviz (autowarefoundation#5986)

* chore: add existence prob for rviz objects

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* chore: adjust text position

Signed-off-by: badai-nguyen <[email protected]>

* fix: add existence prob for tracked and predicted objects

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminoda kminoda kminoda approved these changes

@miursh miursh miursh approved these changes

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo

@scepter914 scepter914 Awaiting requested review from scepter914

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badai-nguyen @miursh @kminoda