Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_auto_perception_rviz_plugin): add existence probability for rviz #5986

Merge branch 'main' into chore/debug/add_existence_prob_for_rviz

515b355
Select commit
Loading
Failed to load commit list.
Merged

chore(autoware_auto_perception_rviz_plugin): add existence probability for rviz #5986

Merge branch 'main' into chore/debug/add_existence_prob_for_rviz
515b355
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 8, 2024 in 42s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 3 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication object_polygon_detail.cpp
  • Complex Method predicted_objects_display.cpp: PredictedObjectsDisplay::createMarkers
  • Complex Method tracked_objects_display.cpp: TrackedObjectsDisplay::processMessage

Annotations

Check warning on line 1 in common/autoware_auto_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Code Duplication

introduced similar code in: get_existence_probability_marker_ptr,get_label_marker_ptr. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 142 in common/autoware_auto_perception_rviz_plugin/src/object_detection/predicted_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

PredictedObjectsDisplay::createMarkers increases in cyclomatic complexity from 15 to 16, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 119 in common/autoware_auto_perception_rviz_plugin/src/object_detection/tracked_objects_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TrackedObjectsDisplay::processMessage increases in cyclomatic complexity from 11 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.