Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnss_poser): use header.frame_id as gnss_frame #6116

Merged
merged 3 commits into from
Jan 22, 2024

style(pre-commit): autofix

d51656f
Select commit
Loading
Failed to load commit list.
Merged

feat(gnss_poser): use header.frame_id as gnss_frame #6116

style(pre-commit): autofix
d51656f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 19, 2024 in 1m 13s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method gnss_poser_core.cpp: GNSSPoser::callbackNavSatFix

Annotations

Check warning on line 146 in sensing/gnss_poser/src/gnss_poser_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

GNSSPoser::callbackNavSatFix already has high cyclomatic complexity, and now it increases in Lines of Code from 90 to 91. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis