-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnss_poser): use header.frame_id as gnss_frame #6116
Merged
KYabuuchi
merged 3 commits into
autowarefoundation:main
from
KYabuuchi:fix/gnss_poser_frame_refers_msg_header
Jan 22, 2024
Merged
feat(gnss_poser): use header.frame_id as gnss_frame #6116
KYabuuchi
merged 3 commits into
autowarefoundation:main
from
KYabuuchi:fix/gnss_poser_frame_refers_msg_header
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kento Yabuuchi <[email protected]>
Signed-off-by: Kento Yabuuchi <[email protected]>
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
labels
Jan 19, 2024
KYabuuchi
changed the title
fix(gnss_poser): use header.frame_id as gnss_frame
feat(gnss_poser): use header.frame_id as gnss_frame
Jan 22, 2024
YamatoAndo
approved these changes
Jan 22, 2024
YamatoAndo
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 22, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6116 +/- ##
=======================================
Coverage 15.18% 15.18%
=======================================
Files 1770 1770
Lines 122425 122424 -1
Branches 37228 37228
=======================================
Hits 18594 18594
+ Misses 82914 82913 -1
Partials 20917 20917
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
…on#6116) * remove gnss_frame param & use header.frame_id to get anntenna's frame_id Signed-off-by: Kento Yabuuchi <[email protected]> * update README Signed-off-by: Kento Yabuuchi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
…on#6116) * remove gnss_frame param & use header.frame_id to get anntenna's frame_id Signed-off-by: Kento Yabuuchi <[email protected]> * update README Signed-off-by: Kento Yabuuchi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…on#6116) * remove gnss_frame param & use header.frame_id to get anntenna's frame_id Signed-off-by: Kento Yabuuchi <[email protected]> * update README Signed-off-by: Kento Yabuuchi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Kento Yabuuchi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #6108
gnss_frame
which indicates antenna's frame_id from parameters.nav_sat_fix.header.frame_id
.(Please note the
header.frame_id
in NavSatFix indicates the frame_id of the antenna, not the Earth or ellipsoid. See also https://docs.ros.org/en/noetic/api/sensor_msgs/html/msg/NavSatFix.html)TIER IV INTERNAL ANNOUNCEMENT LINK
Related PR
Tests performed
I have tested rosbag-replay-simulation in tutorial, and confirmed that the following warnings are not printed.
Effects on system behavior
Basically, this PR does not change the system behavior.
If
header.frame_id
of nav_sat_fix is not set correctly, gnss_poser outputs antenna position instead of base_link position.(However, since this output is only used for initial position estimation, this is not a critical problem.)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.