Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnss_poser): use header.frame_id as gnss_frame #6116

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Jan 19, 2024

Description

This PR resolves #6108

  • Removed gnss_frame which indicates antenna's frame_id from parameters.
  • Changed to identify the antenna's frame_id by referencing nav_sat_fix.header.frame_id.

(Please note the header.frame_id in NavSatFix indicates the frame_id of the antenna, not the Earth or ellipsoid. See also https://docs.ros.org/en/noetic/api/sensor_msgs/html/msg/NavSatFix.html)

TIER IV INTERNAL ANNOUNCEMENT LINK

Related PR

Tests performed

I have tested rosbag-replay-simulation in tutorial, and confirmed that the following warnings are not printed.

[gnss_poser-32] [WARN 1705543736.053584803] [sensing.gnss.gnss_poser]: "gnss" passed to lookupTransform argument source_frame does not exist.
[gnss_poser-32] [WARN 1705543736.053649454] [sensing.gnss.gnss_poser]: Please publish TF base_link to gnss

Effects on system behavior

Basically, this PR does not change the system behavior.

If header.frame_id of nav_sat_fix is not set correctly, gnss_poser outputs antenna position instead of base_link position.
(However, since this output is only used for initial position estimation, this is not a critical problem.)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Jan 19, 2024
@KYabuuchi KYabuuchi changed the title fix(gnss_poser): use header.frame_id as gnss_frame feat(gnss_poser): use header.frame_id as gnss_frame Jan 22, 2024
@KYabuuchi KYabuuchi marked this pull request as ready for review January 22, 2024 01:06
@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 22, 2024
@KYabuuchi KYabuuchi enabled auto-merge (squash) January 22, 2024 09:08
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b4b0002) 15.18% compared to head (d51656f) 15.18%.
Report is 30 commits behind head on main.

Files Patch % Lines
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6116   +/-   ##
=======================================
  Coverage   15.18%   15.18%           
=======================================
  Files        1770     1770           
  Lines      122425   122424    -1     
  Branches    37228    37228           
=======================================
  Hits        18594    18594           
+ Misses      82914    82913    -1     
  Partials    20917    20917           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.18% <ø> (+<0.01%) ⬆️ Carriedforward from b4b0002

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KYabuuchi KYabuuchi merged commit 72b619d into autowarefoundation:main Jan 22, 2024
36 of 40 checks passed
@KYabuuchi KYabuuchi deleted the fix/gnss_poser_frame_refers_msg_header branch January 22, 2024 09:23
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
…on#6116)

* remove gnss_frame param & use header.frame_id to get anntenna's frame_id

Signed-off-by: Kento Yabuuchi <[email protected]>

* update README

Signed-off-by: Kento Yabuuchi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Apr 18, 2024
…on#6116)

* remove gnss_frame param & use header.frame_id to get anntenna's frame_id

Signed-off-by: Kento Yabuuchi <[email protected]>

* update README

Signed-off-by: Kento Yabuuchi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…on#6116)

* remove gnss_frame param & use header.frame_id to get anntenna's frame_id

Signed-off-by: Kento Yabuuchi <[email protected]>

* update README

Signed-off-by: Kento Yabuuchi <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Kento Yabuuchi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gnss_poser fails to get antenna position from base_link in sample data.
2 participants