fix(start/goal_planner): do not call freespace planner callback when not necessary #6125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not necessary Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
kosuke55
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6125 +/- ##
==========================================
- Coverage 14.61% 14.56% -0.06%
==========================================
Files 1859 1860 +1
Lines 127242 127699 +457
Branches 37275 37275
==========================================
Hits 18598 18598
- Misses 87727 88184 +457
Partials 20917 20917
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
…not necessary (autowarefoundation#6125) Signed-off-by: kosuke55 <[email protected]>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 27, 2024
…not necessary (autowarefoundation#6125) Signed-off-by: kosuke55 <[email protected]>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 28, 2024
…not necessary (autowarefoundation#6125) Signed-off-by: kosuke55 <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…not necessary (autowarefoundation#6125) Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not call freespace planner callback when not necessary
Tests performed
evaluator_description: fix/guard_freespace_planner
2024/01/19 https://evaluation.tier4.jp/evaluation/reports/f1f05d54-86e8-5b44-aa4b-631a16a39e81/?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.