-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk)!: improve stuck prevention on crosswalk #6150
Merged
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:feat/crosswalk/improve_stuck_prevention_on_crosswalk
Jan 25, 2024
Merged
feat(crosswalk)!: improve stuck prevention on crosswalk #6150
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:feat/crosswalk/improve_stuck_prevention_on_crosswalk
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 23, 2024
Merged
4 tasks
yuki-takagi-66
requested review from
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
January 23, 2024 06:38
takayuki5168
approved these changes
Jan 24, 2024
takayuki5168
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
=======================================
Coverage 14.60% 14.60%
=======================================
Files 1860 1860
Lines 127418 127417 -1
Branches 37286 37287 +1
=======================================
Hits 18609 18609
+ Misses 87902 87901 -1
Partials 20907 20907
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
merged commit Jan 25, 2024
a49ede7
into
autowarefoundation:main
22 of 25 checks passed
yuki-takagi-66
deleted the
feat/crosswalk/improve_stuck_prevention_on_crosswalk
branch
January 25, 2024 06:28
4 tasks
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Jan 29, 2024
…dation#6150) * improve algorithm * sync param Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: anhnv3991 <[email protected]>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 19, 2024
…dation#6150) * improve algorithm * sync param Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…dation#6150) * improve algorithm * sync param Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improve the stuck prevention function on the crosswalks.
Screencast from 01-23-2024 03:28:44 PM.webm
launch PR: autowarefoundation/autoware_launch#816
Tests performed
psim and tier4 internal tests
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.