Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk)!: improve stuck prevention on crosswalk #6150

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 23, 2024

Description

This PR improve the stuck prevention function on the crosswalks.
Screencast from 01-23-2024 03:28:44 PM.webm
launch PR: autowarefoundation/autoware_launch#816

Tests performed

psim and tier4 internal tests

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (f5cef6c) 14.60% compared to head (2ce6841) 14.60%.
Report is 23 commits behind head on main.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 17 Missing ⚠️
...behavior_velocity_crosswalk_module/src/manager.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6150   +/-   ##
=======================================
  Coverage   14.60%   14.60%           
=======================================
  Files        1860     1860           
  Lines      127418   127417    -1     
  Branches    37286    37287    +1     
=======================================
  Hits        18609    18609           
+ Misses      87902    87901    -1     
  Partials    20907    20907           
Flag Coverage Δ *Carryforward flag
differential 11.66% <0.00%> (?)
total 14.60% <ø> (+<0.01%) ⬆️ Carriedforward from 3082354

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 merged commit a49ede7 into autowarefoundation:main Jan 25, 2024
22 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/crosswalk/improve_stuck_prevention_on_crosswalk branch January 25, 2024 06:28
@yuki-takagi-66 yuki-takagi-66 mentioned this pull request Jan 25, 2024
4 tasks
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
…dation#6150)

* improve algorithm
* sync param

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: anhnv3991 <[email protected]>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants