feat(crosswalk)!: improve stuck prevention on crosswalk #6150
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jan 25, 2024 in 2m 0s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Overall Code Complexity scene_crosswalk.cpp
- Complex Method scene_crosswalk.cpp: CrosswalkModule::checkStopForStuckVehicles
Annotations
Check notice on line 950 in planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
CrosswalkModule::checkStopForStuckVehicles decreases in cyclomatic complexity from 21 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.03 to 5.97, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading