Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shape_estimation): rework parameters #6157

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 24, 2024

Description

Remove unnecessary param from launcher

Tests performed

Not tested

Effects on system behavior

No effect expected

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 24, 2024
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 24, 2024
@kminoda kminoda enabled auto-merge (squash) January 24, 2024 10:59
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4cae6f) 14.58% compared to head (9d96b39) 14.58%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6157   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1868     1868           
  Lines      127493   127493           
  Branches    37317    37317           
=======================================
  Hits        18600    18600           
  Misses      87974    87974           
  Partials    20919    20919           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.58% <ø> (ø) Carriedforward from e4cae6f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit 007d156 into autowarefoundation:main Jan 24, 2024
36 of 37 checks passed
@kminoda kminoda changed the title chore(shape_estimation): remove unnecessary param chore(shape_estimation): rework parameters Jan 25, 2024
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@kminoda kminoda deleted the chore/shape_estimation/remove_unnecessary_param branch June 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants