Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shape estimation): 5330 + 6157 + 6598 #1199

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Mar 19, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

PhoebeWu21 and others added 3 commits March 19, 2024 23:05
* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <[email protected]>

* style(pre-commit): autofix

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <[email protected]>

* refactor(shape_estimation): rework parameters

Signed-off-by: PhoebeWu21 <[email protected]>

---------

Signed-off-by: PhoebeWu21 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… by camera_lidar_fusion as unknown (autowarefoundation#6598)

* fix(shape_estimation): keep excluded objects as unknown

Signed-off-by: badai-nguyen <[email protected]>

* chore: add optional param

Signed-off-by: badai-nguyen <[email protected]>

* chore: rename param

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Yoshi Ri <[email protected]>
@badai-nguyen badai-nguyen requested a review from shmpwk March 19, 2024 14:13
@badai-nguyen badai-nguyen changed the title hotfix(shape estimation): rework and preserve irregular large size vehicle cherry-pick(shape estimation): 5330 + 6157 + 6598 Mar 19, 2024
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shmpwk shmpwk changed the title cherry-pick(shape estimation): 5330 + 6157 + 6598 fix(shape estimation): 5330 + 6157 + 6598 Mar 19, 2024
@shmpwk shmpwk enabled auto-merge March 19, 2024 14:28
@shmpwk shmpwk merged commit 18755b5 into beta/v0.20.1.5 Mar 19, 2024
17 of 22 checks passed
@shmpwk shmpwk deleted the hotfix/shape_estimation branch March 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants