chore(cluster_merger): rework parameters #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:perception
kminoda
added
the
run:build-and-test-differential
kminoda
requested review from
badai-nguyen,
miursh and
yukkysaito
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6165 +/- ##
==========================================
+ Coverage 14.58% 14.60% +0.01%
==========================================
Files 1871 1868 -3
Lines 127544 127316 -228
Branches 37310 37297 -13
==========================================
- Hits 18608 18593 -15
+ Misses 88017 87810 -207
+ Partials 20919 20913 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
changed the title
yukkysaito
approved these changes
Jan 26, 2024
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Jan 29, 2024
chore(cluster_merger): organize parameter Signed-off-by: kminoda <[email protected]> Signed-off-by: anhnv3991 <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
chore(cluster_merger): organize parameter Signed-off-by: kminoda <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
chore(cluster_merger): organize parameter Signed-off-by: kminoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parametrize a parameter declared in launch file
Tests performed
Build and launched the node and confirmed that the param is loaded.
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.