Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception): add pipeline_latency_ms publisher #6181

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 26, 2024

Description

Related to #6056

Introduce pipeline_latency_ms measurement in perception nodes as well.

Tests performed

Launch Autoware and confirmed that following topics are launched.

$ ros2 topic list | grep pipeline
/perception/object_recognition/detection/centerpoint/lidar_centerpoint/debug/pipeline_latency_ms
/perception/object_recognition/detection/clustering/voxel_grid_based_euclidean_cluster/debug/pipeline_latency_ms
/perception/object_recognition/detection/object_lanelet_filter/debug/pipeline_latency_ms
/perception/object_recognition/detection/obstacle_pointcloud_based_validator/debug/pipeline_latency_ms
/perception/occupancy_grid_map/pointcloud_based_occupancy_grid_map/debug/pipeline_latency_ms
$ ros2 topic echo /perception/object_recognition/detection/object_lanelet_filter/debug/pipeline_latency_ms
...
---
stamp:  
  sec: 1585897275
  nanosec: 720424035
data: 284.023139  
---    
...

Effects on system behavior

The number of published messages in total will increase. (The effect on network traffic is expected to be limited)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda changed the title feat: add accumulated_time publisher fea(perception)t: add accumulated_time publisher Jan 26, 2024
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 26, 2024
@kminoda kminoda changed the title fea(perception)t: add accumulated_time publisher fea(perception)t: add pipeline_latency_ms publisher Jan 26, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 26, 2024
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jan 26, 2024
@kminoda kminoda force-pushed the feat/perception/add_accumulated_time_publisher branch from 9f5adaf to 4214d00 Compare January 26, 2024 01:41
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 26, 2024
@kminoda kminoda changed the title fea(perception)t: add pipeline_latency_ms publisher feaf(perception): add pipeline_latency_ms publisher Jan 26, 2024
@kminoda kminoda changed the title feaf(perception): add pipeline_latency_ms publisher feat(perception): add pipeline_latency_ms publisher Jan 26, 2024
@kminoda kminoda marked this pull request as ready for review January 29, 2024 03:16
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (f514bca) 14.58% compared to head (be2e218) 14.58%.
Report is 7 commits behind head on main.

Files Patch % Lines
...dation/src/obstacle_pointcloud_based_validator.cpp 0.00% 5 Missing ⚠️
...ed_object_validation/src/object_lanelet_filter.cpp 0.00% 4 Missing ⚠️
...n/euclidean_cluster/src/euclidean_cluster_node.cpp 0.00% 4 Missing ⚠️
...er/src/voxel_grid_based_euclidean_cluster_node.cpp 0.00% 4 Missing ⚠️
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% 3 Missing ⚠️
perception/lidar_centerpoint/src/node.cpp 0.00% 3 Missing ⚠️
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6181      +/-   ##
==========================================
- Coverage   14.58%   14.58%   -0.01%     
==========================================
  Files        1877     1877              
  Lines      128013   128037      +24     
  Branches    37468    37470       +2     
==========================================
+ Hits        18672    18673       +1     
- Misses      88367    88388      +21     
- Partials    20974    20976       +2     
Flag Coverage Δ *Carryforward flag
differential 8.38% <3.84%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from f514bca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@xmfcx xmfcx merged commit 83f698d into autowarefoundation:main Feb 9, 2024
20 of 24 checks passed
@kminoda kminoda deleted the feat/perception/add_accumulated_time_publisher branch February 9, 2024 08:55
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants