Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(yabloc_pose_initializer): fix dependencies #6190

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 26, 2024

Description

Missing dependencies for yabloc_pose_initializer that uses OpenCV

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jan 26, 2024
@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 26, 2024
@esteve esteve force-pushed the fix-deps-yabloc-pose-initializer branch from 60a8b81 to ad2b6e1 Compare January 26, 2024 15:51
@esteve esteve marked this pull request as ready for review January 26, 2024 15:52
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccd852b) 14.58% compared to head (ad2b6e1) 14.58%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6190   +/-   ##
=======================================
  Coverage   14.58%   14.58%           
=======================================
  Files        1871     1871           
  Lines      127545   127543    -2     
  Branches    37311    37311           
=======================================
  Hits        18606    18606           
+ Misses      88019    88017    -2     
  Partials    20920    20920           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from ccd852b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve merged commit e67ab70 into main Jan 29, 2024
25 checks passed
@esteve esteve deleted the fix-deps-yabloc-pose-initializer branch January 29, 2024 10:41
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants