-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): update filtering logic for non-vehicle #6206
fix(avoidance): update filtering logic for non-vehicle #6206
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6206 +/- ##
==========================================
- Coverage 14.58% 14.58% -0.01%
==========================================
Files 1878 1878
Lines 128023 128037 +14
Branches 37468 37474 +6
==========================================
Hits 18673 18673
- Misses 88376 88390 +14
Partials 20974 20974
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
fix(avoidance): update filtering logic for non-vehicle (autowarefoundation#6206)
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
…ation#6206) Signed-off-by: satoshi-ota <[email protected]>
Description
Fow now, unknown objects tracking result is more unstable than other class objects. Sometimes, ghost unknown object is detected and avoidance module generates unnecessary path.
In this PR, I added another target filtering logic for unknown to keep current path until module confirmed the unknown is actually exist and keeps stopping more that 3.0 seconds.
Related Ticket: https://tier4.atlassian.net/browse/RT1-5044
simplescreenrecorder-2024-01-29_11.47.52.mp4
Tests performed
Effects on system behavior
Suppress unnecessary avoidance behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.