Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): update filtering logic for non-vehicle #6206

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jan 29, 2024

Description

Fow now, unknown objects tracking result is more unstable than other class objects. Sometimes, ghost unknown object is detected and avoidance module generates unnecessary path.

In this PR, I added another target filtering logic for unknown to keep current path until module confirmed the unknown is actually exist and keeps stopping more that 3.0 seconds.

Related Ticket: https://tier4.atlassian.net/browse/RT1-5044

simplescreenrecorder-2024-01-29_11.47.52.mp4

Tests performed

Effects on system behavior

Suppress unnecessary avoidance behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 29, 2024
@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (f9ed5b0) 14.58% compared to head (7bad705) 14.58%.
Report is 6 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/utils.cpp 0.00% 15 Missing ⚠️
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6206      +/-   ##
==========================================
- Coverage   14.58%   14.58%   -0.01%     
==========================================
  Files        1878     1878              
  Lines      128023   128037      +14     
  Branches    37468    37474       +6     
==========================================
  Hits        18673    18673              
- Misses      88376    88390      +14     
  Partials    20974    20974              
Flag Coverage Δ *Carryforward flag
differential 13.08% <0.00%> (?)
total 14.58% <ø> (+<0.01%) ⬆️ Carriedforward from f9ed5b0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 0db40ae into autowarefoundation:main Jan 30, 2024
45 of 49 checks passed
@satoshi-ota satoshi-ota deleted the feat/improve-unknown-filtering branch January 30, 2024 02:04
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jan 30, 2024
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Jan 30, 2024
fix(avoidance): update filtering logic for non-vehicle (autowarefoundation#6206)
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants