-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(radar_tracks_msgs_converter): add config #6213
chore(radar_tracks_msgs_converter): add config #6213
Conversation
Signed-off-by: scepter914 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Confirmed that
- Autoware launches with this PR (and related PRs).
- Parameters are successfully modified when I modify the .param.yaml file.
See also: TIER IV INTERNAL LINK FOR REWORK PRs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6213 +/- ##
=======================================
Coverage 14.39% 14.40%
=======================================
Files 1906 1906
Lines 129847 129837 -10
Branches 37572 37569 -3
=======================================
Hits 18697 18697
+ Misses 90155 90145 -10
Partials 20995 20995
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: scepter914 <[email protected]>
Signed-off-by: scepter914 <[email protected]>
Description
Add a config file to
radar_tracks_msgs_converter
Tests performed
Test by rosbag
Effects on system behavior
No
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.