Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(traffic_light_fine_detector_and_classifier): rework parameters #6216

style(pre-commit): autofix

33e2c3a
Select commit
Loading
Failed to load commit list.
Merged

chore(traffic_light_fine_detector_and_classifier): rework parameters #6216

style(pre-commit): autofix
33e2c3a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 29, 2024 in 1m 18s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Large Method traffic_light_node_container.launch.py: generate_launch_description

Annotations

Check notice on line 231 in launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light_node_container.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Large Method

generate_launch_description is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 159 in launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light_node_container.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Large Method

launch_setup has 124 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.