-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(map_tf_generator): rework parameters #6233
refactor(map_tf_generator): rework parameters #6233
Conversation
Signed-off-by: Yamato Ando <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I executed the logging_simulator
using AWSIM data and confirmed that autoware works with almost the same evaluation values as before.
I also confirmed that the parameters are displayed correctly with mkdocs serve
.
Signed-off-by: Yamato Ando <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
==========================================
- Coverage 14.91% 14.40% -0.52%
==========================================
Files 1817 1906 +89
Lines 125357 129839 +4482
Branches 37640 37571 -69
==========================================
+ Hits 18697 18699 +2
- Misses 85651 90146 +4495
+ Partials 21009 20994 -15
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* refactor(map_tf_generator): rework parameters Signed-off-by: Yamato Ando <[email protected]> * add config Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(map_tf_generator): rework parameters Signed-off-by: Yamato Ando <[email protected]> * add config Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* refactor(map_tf_generator): rework parameters Signed-off-by: Yamato Ando <[email protected]> * add config Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Merge with autowarefoundation/autoware_launch#835
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371.
Parameters
chapter in the readme file.Tests performed
Lsim works.
passed check-jsonschema.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.