Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(start_planner): disable safety check against dynamic objects when ego polygon overlap with centerline #6236
feat(start_planner): disable safety check against dynamic objects when ego polygon overlap with centerline #6236
Changes from 5 commits
f6bbeed
54fcb65
fd62172
7a549e5
ea43fef
fe845a9
c0408f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 1 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how abount just check intersection of polygon and lines not giving 4 points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it is possible with boost geometry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyoichi-sugahara said tier4 utils is fater
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kosuke55
I'm using it because this computational cost is low
Check warning on line 312 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
Check warning on line 312 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Deep, Nested Complexity