fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6432

h-ohta · 2024-02-16T03:37:55Z

Description

I fix spell check failures to ignore LOBF, bcnn, CTRV and DLCPU.
I followed ↓.

autoware.universe/common/tvm_utility/data/models/abs_model_aarch64/inference_engine_tvm_config.hpp

Line 40 in 6b1a459

// cspell: ignore DLCPU

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2024-02-16T06:15:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.79%. Comparing base (c09c176) to head (b8efcff).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6432   +/-   ##
=======================================
  Coverage   14.79%   14.79%           
=======================================
  Files        1917     1917           
  Lines      131984   131984           
  Branches    39228    39228           
=======================================
  Hits        19524    19524           
  Misses      90671    90671           
  Partials    21789    21789

Flag	Coverage Δ		*Carryforward flag
differential	`7.87% <ø> (?)`
total	`14.79% <ø> (ø)`		Carriedforward from c09c176

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YoshiRi

Thanks, LGTM

ambroise-arm · 2024-02-20T08:50:26Z

How is it decided when to add a word to the dictionary and when to ignore it in the codebase?

h-ohta · 2024-02-21T23:47:06Z

@ambroise-arm
These words are not common because they are not in the dictionary and are only used in specific nodes.
So I decided them to ignore by codebase.

h-ohta · 2024-02-26T01:03:33Z

@soblin @yukkysaito @angry-crab Could you review this PR?

yukkysaito

LGTM

h-ohta · 2024-03-01T01:31:59Z

For some reason, json-schema-check action is not working...
I'll close this PR and recreate it.

h-ohta · 2024-03-01T01:53:50Z

@xmfcx This PR is blocked by json-schema-check.
Because it is specified as required action.
This PR don't edit schema.json or param.yaml.
Could you check and fix it ?

HansRobo · 2024-03-01T02:09:29Z

I made a pull-request for this problem.
#6524

h-ohta · 2024-03-01T09:18:51Z

@angry-crab I appreciate it if you review this PR.

angry-crab

LGTM

angry-crab · 2024-03-04T02:46:49Z

Appologies for late response

#6432) fix: suppress spell check failure to ignore LOBF, bcnn, CTRV Signed-off-by: Kotaro Yoshimoto <[email protected]>

autowarefoundation#6432) fix: suppress spell check failure to ignore LOBF, bcnn, CTRV Signed-off-by: kaigohirao <[email protected]>

autowarefoundation#6432) fix: suppress spell check failure to ignore LOBF, bcnn, CTRV

h-ohta requested review from soblin, YoshiRi, yukkysaito, angry-crab and ambroise-arm as code owners February 16, 2024 03:37

github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 16, 2024

h-ohta enabled auto-merge (squash) February 16, 2024 05:45

h-ohta added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 16, 2024

YoshiRi approved these changes Feb 19, 2024

View reviewed changes

h-ohta changed the title ~~fix: suppress spell check failure to ignore LOBF, bcnn, CTRV~~ fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU Feb 21, 2024

ambroise-arm approved these changes Feb 22, 2024

View reviewed changes

soblin approved these changes Feb 26, 2024

View reviewed changes

yukkysaito approved these changes Feb 26, 2024

View reviewed changes

h-ohta added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 26, 2024

h-ohta disabled auto-merge March 1, 2024 00:50

h-ohta enabled auto-merge (squash) March 1, 2024 00:50

h-ohta force-pushed the fix/ignore_spell_check branch from eadd0a5 to 3430230 Compare March 1, 2024 01:28

h-ohta closed this Mar 1, 2024

auto-merge was automatically disabled March 1, 2024 01:31
Pull request was closed

h-ohta reopened this Mar 1, 2024

h-ohta closed this Mar 1, 2024

h-ohta mentioned this pull request Mar 1, 2024

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6523

Closed

7 tasks

h-ohta reopened this Mar 1, 2024

h-ohta enabled auto-merge (squash) March 1, 2024 01:51

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV

b8efcff

xmfcx force-pushed the fix/ignore_spell_check branch from 3430230 to b8efcff Compare March 1, 2024 04:05

angry-crab approved these changes Mar 4, 2024

View reviewed changes

h-ohta merged commit 833722b into main Mar 4, 2024
23 checks passed

h-ohta deleted the fix/ignore_spell_check branch March 4, 2024 02:46

HansRobo pushed a commit that referenced this pull request Mar 12, 2024

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU (

2113688

#6432) fix: suppress spell check failure to ignore LOBF, bcnn, CTRV Signed-off-by: Kotaro Yoshimoto <[email protected]>

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU (

e9ac753

autowarefoundation#6432) fix: suppress spell check failure to ignore LOBF, bcnn, CTRV

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6432

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6432

h-ohta commented Feb 16, 2024 •

edited

Loading

codecov bot commented Feb 16, 2024 •

edited

Loading

YoshiRi left a comment

ambroise-arm commented Feb 20, 2024

h-ohta commented Feb 21, 2024 •

edited

Loading

h-ohta commented Feb 26, 2024

yukkysaito left a comment

h-ohta commented Mar 1, 2024 •

edited

Loading

h-ohta commented Mar 1, 2024 •

edited

Loading

HansRobo commented Mar 1, 2024

h-ohta commented Mar 1, 2024

angry-crab left a comment

angry-crab commented Mar 4, 2024

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6432

fix: suppress spell check failure to ignore LOBF, bcnn, CTRV and DLCPU #6432

Conversation

h-ohta commented Feb 16, 2024 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Feb 16, 2024 • edited Loading

Codecov Report

YoshiRi left a comment

Choose a reason for hiding this comment

ambroise-arm commented Feb 20, 2024

h-ohta commented Feb 21, 2024 • edited Loading

h-ohta commented Feb 26, 2024

yukkysaito left a comment

Choose a reason for hiding this comment

h-ohta commented Mar 1, 2024 • edited Loading

h-ohta commented Mar 1, 2024 • edited Loading

HansRobo commented Mar 1, 2024

h-ohta commented Mar 1, 2024

angry-crab left a comment

Choose a reason for hiding this comment

angry-crab commented Mar 4, 2024

h-ohta commented Feb 16, 2024 •

edited

Loading

codecov bot commented Feb 16, 2024 •

edited

Loading

h-ohta commented Feb 21, 2024 •

edited

Loading

h-ohta commented Mar 1, 2024 •

edited

Loading

h-ohta commented Mar 1, 2024 •

edited

Loading