Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_obstacle_stop): add option to ignore unavoidable collisions #6594

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Mar 11, 2024

Description

Add an option to ignore unavoidable collisions with the dynamic_obstacle_stop module.
If an object is detected as heading straight toward the ego vehicle, such that even if ego stops the collision would be unavoidable, then the object is ignored by the module.
This is to avoid sudden stops caused by noise in the perception.

Required launch PR: autowarefoundation/autoware_launch#916

(TIER IV INTERNAL LINK) https://tier4.atlassian.net/browse/RT1-5690

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem requested a review from soblin as a code owner March 11, 2024 23:51
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 11, 2024
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 12, 2024
@maxime-clem maxime-clem force-pushed the dyn_obs_stop/ignore-straight-facing-obs_universe branch from a8b99e9 to b1dc13a Compare March 12, 2024 02:26
maxime-clem and others added 5 commits March 19, 2024 11:59
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem force-pushed the dyn_obs_stop/ignore-straight-facing-obs_universe branch from de8fc13 to c8fcac8 Compare March 19, 2024 03:17
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (1ca97cf) to head (1a7af2d).

Files Patch % Lines
...amic_obstacle_stop_module/src/object_filtering.cpp 0.00% 23 Missing ⚠️
...le_stop_module/src/scene_dynamic_obstacle_stop.cpp 0.00% 12 Missing ⚠️
...ocity_dynamic_obstacle_stop_module/src/manager.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6594      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1925     1925              
  Lines      132699   132721      +22     
  Branches    39515    39515              
==========================================
  Hits        19625    19625              
- Misses      91101    91123      +22     
  Partials    21973    21973              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 1ca97cf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 1cbdfa3 into autowarefoundation:main Mar 19, 2024
36 of 41 checks passed
@maxime-clem maxime-clem deleted the dyn_obs_stop/ignore-straight-facing-obs_universe branch March 19, 2024 07:08
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants