-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamic_obstacle_stop): add option to ignore unavoidable collisions #6594
Merged
maxime-clem
merged 6 commits into
autowarefoundation:main
from
maxime-clem:dyn_obs_stop/ignore-straight-facing-obs_universe
Mar 19, 2024
Merged
feat(dynamic_obstacle_stop): add option to ignore unavoidable collisions #6594
maxime-clem
merged 6 commits into
autowarefoundation:main
from
maxime-clem:dyn_obs_stop/ignore-straight-facing-obs_universe
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Mar 11, 2024
4 tasks
github-actions
bot
added
the
type:documentation
Creating or refining documentation. (auto-assigned)
label
Mar 12, 2024
maxime-clem
force-pushed
the
dyn_obs_stop/ignore-straight-facing-obs_universe
branch
from
March 12, 2024 02:26
a8b99e9
to
b1dc13a
Compare
soblin
reviewed
Mar 18, 2024
planning/behavior_velocity_dynamic_obstacle_stop_module/src/object_filtering.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
soblin
approved these changes
Mar 19, 2024
maxime-clem
force-pushed
the
dyn_obs_stop/ignore-straight-facing-obs_universe
branch
from
March 19, 2024 03:17
de8fc13
to
c8fcac8
Compare
Signed-off-by: Maxime CLEMENT <[email protected]>
maxime-clem
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Mar 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6594 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1925 1925
Lines 132699 132721 +22
Branches 39515 39515
==========================================
Hits 19625 19625
- Misses 91101 91123 +22
Partials 21973 21973
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
deleted the
dyn_obs_stop/ignore-straight-facing-obs_universe
branch
March 19, 2024 07:08
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 19, 2024
…ons (autowarefoundation#6594) Signed-off-by: Maxime CLEMENT <[email protected]>
4 tasks
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…ons (autowarefoundation#6594) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: kaigohirao <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…ons (autowarefoundation#6594) Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to ignore unavoidable collisions with the
dynamic_obstacle_stop
module.If an object is detected as heading straight toward the ego vehicle, such that even if ego stops the collision would be unavoidable, then the object is ignored by the module.
This is to avoid sudden stops caused by noise in the perception.
Required launch PR: autowarefoundation/autoware_launch#916
(TIER IV INTERNAL LINK) https://tier4.atlassian.net/browse/RT1-5690
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.