Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dummy_perception_publisher): add adaptive tp_rate #6736

Closed

add adaptive xy, yaw noise

1352960
Select commit
Loading
Failed to load commit list.
Closed

feat(dummy_perception_publisher): add adaptive tp_rate #6736

add adaptive xy, yaw noise
1352960
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Apr 4, 2024 in 43s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method node.cpp: DummyPerceptionPublisherNode::timerCallback
  • Overall Function Size node.cpp
  • Overall Code Complexity node.cpp
  • Complex Conditional node.cpp: DummyPerceptionPublisherNode::DummyPerceptionPublisherNode

Annotations

Check warning on line 1 in simulator/dummy_perception_publisher/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Function Size

The median function size in this module is 57.0 LOC, threshold = 50.0. This file contains overly long functions, measured by their lines of code.

Check warning on line 301 in simulator/dummy_perception_publisher/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

DummyPerceptionPublisherNode::timerCallback already has high cyclomatic complexity, and now it increases in Lines of Code from 123 to 128. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 155 in simulator/dummy_perception_publisher/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

DummyPerceptionPublisherNode::DummyPerceptionPublisherNode has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 1 in simulator/dummy_perception_publisher/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 8.00 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.