feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7027

vividf · 2024-05-15T10:18:04Z

Description

This PR solved the issue #6657.
This PR provides an option for the user to choose a 3d distortion corrector instead of using the current 2d distortion corrector.

Note that by using this, the time will increase around 50 percent.

Tests performed

Time comparison

Input: mirrored pointcloud (58 frames)
distortion corrector: 2d

Before the PR

	Minimum	Maximum	Average
Time	7.15	15.29	10.09

After the PR

	Minimum	Maximum	Average
Time	7.36	14.01	10.40

Input: mirror pointcloud (58 frames)
distortion corrector: 3d

After the PR

	Minimum	Maximum	Average
Time	13.02	22.26	16.05

Pointcloud comparison

https://github.com/meliketanrikulu will provide more detail.

Notes for reviewers

Interface changes

Additional parameter is added use_3d_distortion_correction, the default value is false

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

vividf · 2024-05-15T10:46:58Z

@meliketanrikulu
Could you test this PR again with your scenarios and provide some results here? Thanks!

Please note that you need to set the parameter to true.

xmfcx · 2024-05-15T11:38:44Z

Could you also update the readme of this package?

And add @vividf (yourself) and @meliketanrikulu (Melike Tanrıkulu) to the package maintainers under the package.xml?

sensing/pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp

xmfcx · 2024-05-15T11:43:17Z

For the PR title, please follow: https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/#apply-conventional-commits-to-the-pull-request-title-required-automated

Or you won't pass this required test.

github-actions · 2024-05-15T12:48:37Z

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7027/
Modified URLs:

Signed-off-by: vividf <[email protected]>

…arefoundation#6910) * fix(trajectory_follower_node): fix config file of plot juggler Signed-off-by: tomoya.kimura <[email protected]> * fix spells Signed-off-by: tomoya.kimura <[email protected]> * fix: ignore spell check for "ROS2" Signed-off-by: tomoya.kimura <[email protected]> * fix spells Signed-off-by: tomoya.kimura <[email protected]> --------- Signed-off-by: tomoya.kimura <[email protected]> Signed-off-by: vividf <[email protected]>

…towarefoundation#6916) Signed-off-by: vividf <[email protected]>

…oundation#6914) * docs(tier4_simulated_clock_rviz_plugin): update how to use Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fixed tabbed warning Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix warning not working Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Fix bullet list Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

* refactor(avoidance): rebuild object info structure Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): add helper function to unify same process Signed-off-by: satoshi-ota <[email protected]> * refactor(avoidance): remove unused header Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: vividf <[email protected]>

…refoundation#6918) * feat(mission_planner): publish initial and goal poses to logs Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * refactoring to a function Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

…hance requirements on documenting interface changes (autowarefoundation#6896) improve the pull request template to enhance requirements on documenting interface changes Signed-off-by: Yuxuan Liu <[email protected]> Co-authored-by: Yuxuan Liu <[email protected]> Signed-off-by: vividf <[email protected]>

…os to besteffort (autowarefoundation#6864) feat: change radar tracks subscription qos to besteffort Signed-off-by: yoshiri <[email protected]> Signed-off-by: vividf <[email protected]>

…to ogm creation (autowarefoundation#6865) * feat: add downsample filter to ogm creation Signed-off-by: yoshiri <[email protected]> * feat: add downsample to multi_lidar ogm creation Signed-off-by: yoshiri <[email protected]> * chore: update package.xml and readme and param file Signed-off-by: yoshiri <[email protected]> * chore: update readme document Signed-off-by: yoshiri <[email protected]> * chore: fix downsample size Signed-off-by: yoshiri <[email protected]> * chore: fix cspell error Signed-off-by: yoshiri <[email protected]> * feat: add test_depend Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]> Signed-off-by: vividf <[email protected]>

autowarefoundation#6926) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: vividf <[email protected]>

fix: do not use c++20 keyword as a type alias Signed-off-by: Grzegorz Głowacki <[email protected]> Signed-off-by: vividf <[email protected]>

…owarefoundation#6921) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: vividf <[email protected]>

…foundation#6922) Signed-off-by: vividf <[email protected]>

autowarefoundation#6917) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

…foundation#6797) * fix(occupancy_grid_map_outlier_filter): add intensity field Signed-off-by: badai-nguyen <[email protected]> * fix: add intensity Signed-off-by: badai-nguyen <[email protected]> * fix: using empty padding field Signed-off-by: badai-nguyen <[email protected]> * refactor Signed-off-by: badai-nguyen <[email protected]> * Revert "refactor" This reverts commit d16b3e0. * refactor Signed-off-by: badai-nguyen <[email protected]> * fix: radius filter Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * fix: typo Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: vividf <[email protected]>

Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: vividf <[email protected]>

* refactor(lane_change): rework object filter Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Use preceeding lanes Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * style(pre-commit): autofix * fix preceding lanes Signed-off-by: Zulfaqar Azmi <[email protected]> * Adds flow chart Signed-off-by: Zulfaqar Azmi <[email protected]> * prioritize on coming object check instead Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Fix flow chart and rearrange code to early return Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Colorize flow chart Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: Zulfaqar Azmi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: vividf <[email protected]>

Signed-off-by: vividf <[email protected]>

* feat: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * modify: componentize-system_error_monitor Signed-off-by: TetsuKawa <[email protected]> * feat: add explicit Signed-off-by: TetsuKawa <[email protected]> --------- Signed-off-by: TetsuKawa <[email protected]> Signed-off-by: vividf <[email protected]>

…ndation#6995) * refactor(autoware_planning_test_manager): rename package Signed-off-by: Zulfaqar Azmi <[email protected]> * rename file Signed-off-by: Zulfaqar Azmi <[email protected]> * Add maintainer for planning test utils Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * Add route handler back into package.xml Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

…ion#7025) Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: vividf <[email protected]>

…n#7023) Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: vividf <[email protected]>

…7026) Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

… autoware_ (autowarefoundation#6817) * build(static_centerline_generator): prefix package and namespace with autoware_ Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build: fix CMake target Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_static_centerline_generator): more renames Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_static_centerline_generator): fix namespace Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix build issues Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix build issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_optimizer): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * build: fix build errors Signed-off-by: Esteve Fernandez <[email protected]> * fix: remove else statements after return Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix clang-tidy issues Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * revert changes for static_centerline_generator Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): add autoware_ prefix Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix filenames Signed-off-by: Esteve Fernandez <[email protected]> * fix(autoware_static_centerline_generator): fix namespaces Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * fix: added prefix to missing strings Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_static_centerline_generator): move header files to src Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_static_centerline_generator): fix include paths Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix Signed-off-by: Esteve Fernandez <[email protected]> * refactor(autoware_static_centerline_generator): rename base folder Signed-off-by: Esteve Fernandez <[email protected]> * Update planning/autoware_static_centerline_generator/launch/static_centerline_generator.launch.xml Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_static_centerline_generator): fix include in CMake Signed-off-by: Esteve Fernandez <[email protected]> * build(autoware_static_centerline_generator): fix missing includes Signed-off-by: Esteve Fernandez <[email protected]> --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: vividf <[email protected]>

…oint query (autowarefoundation#7020) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: vividf <[email protected]>

…and node names (autowarefoundation#7028) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: vividf <[email protected]>

…towarefoundation#7012) remove unused functions in route_handler Signed-off-by: vividf <[email protected]>

vividf · 2024-05-16T03:30:50Z

As one of the commits (suggested by the reviewer) didn't have the signoff, I followed the GitHub suggestion.
However, it makes this PR hard to review by having too many unrelated changes.

I created a new PR at #7031.
Sorry for the inconvenience @xmfcx @meliketanrikulu

github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label May 15, 2024

vividf mentioned this pull request May 15, 2024

The distortion corrector package doesn't compensate for all motion distortion #6657

Closed

5 tasks

xmfcx requested a review from meliketanrikulu May 15, 2024 11:36

xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 15, 2024

xmfcx assigned vividf May 15, 2024

xmfcx added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label May 15, 2024

xmfcx reviewed May 15, 2024

View reviewed changes

sensing/pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp Outdated Show resolved Hide resolved

vividf changed the title ~~Feature/3d distortion corrector~~ feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node May 16, 2024

github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label May 16, 2024

vividf and others added 17 commits May 16, 2024 12:11

add support for 3d distortion corrector

87062b6

Signed-off-by: vividf <[email protected]>

chore(component_state_monitor): relax pose_estimator_pose timeout (au…

7675df2

…towarefoundation#6916) Signed-off-by: vividf <[email protected]>

chore(radar_track_msgs_converter): change radar tracks subscription q…

de94fc4

…os to besteffort (autowarefoundation#6864) feat: change radar tracks subscription qos to besteffort Signed-off-by: yoshiri <[email protected]> Signed-off-by: vividf <[email protected]>

fix(behavior_path_planner_common): fix warning of containerOutOfBounds (

7ace304

autowarefoundation#6926) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: vividf <[email protected]>

fix: do not use c++20 char8_t keyword (autowarefoundation#3629)

5f0ae9c

fix: do not use c++20 keyword as a type alias Signed-off-by: Grzegorz Głowacki <[email protected]> Signed-off-by: vividf <[email protected]>

fix(control_performance_analysis): fix bug of ignoredReturnValue (aut…

2b69477

…owarefoundation#6921) Signed-off-by: Ryuta Kambe <[email protected]> Signed-off-by: vividf <[email protected]>

fix(perception_online_evaluator): fix bug of constStatement (autoware…

7b91f0d

…foundation#6922) Signed-off-by: vividf <[email protected]>

refactor(bpp): path shifter clang tidy and logging level configuration (

bc3425f

autowarefoundation#6917) Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

feat(crosswalk)!: change ego min assumed speed (autowarefoundation#6904)

10c3636

Signed-off-by: Yuki Takagi <[email protected]> Signed-off-by: vividf <[email protected]>

vividf and others added 11 commits May 16, 2024 12:11

fix readme

32e1beb

Signed-off-by: vividf <[email protected]>

fix more readme

293824d

Signed-off-by: vividf <[email protected]>

feat(diagnostic_graph_aggregator): componentize node (autowarefoundat…

b5edd91

…ion#7025) Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: vividf <[email protected]>

feat(component_interface_tools): componentize node (autowarefoundatio…

a2b8711

…n#7023) Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: vividf <[email protected]>

chore(simple_planning_simulator): add maintainer (autowarefoundation#…

7d66313

…7026) Signed-off-by: Zulfaqar Azmi <[email protected]> Signed-off-by: vividf <[email protected]>

perf(map_height_fitter): find z value with a more efficient closest p…

8d57d3f

…oint query (autowarefoundation#7020) Signed-off-by: Maxime CLEMENT <[email protected]> Signed-off-by: vividf <[email protected]>

fix(autoware_static_centerline_generator): remove prefix from topics …

069bac2

…and node names (autowarefoundation#7028) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: vividf <[email protected]>

refactor(route_handler): remove unused functions in route_handler (au…

fabb0e0

…towarefoundation#7012) remove unused functions in route_handler Signed-off-by: vividf <[email protected]>

vividf force-pushed the feature/3d_distortion_corrector branch from f5eca32 to fabb0e0 Compare May 16, 2024 03:13

vividf closed this May 16, 2024

vividf deleted the feature/3d_distortion_corrector branch May 16, 2024 03:27

meliketanrikulu mentioned this pull request May 16, 2024

feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7031

Closed

7 tasks

vividf mentioned this pull request May 29, 2024

chore(pointcloud_preprocessor): add maintainers to pointcloud preprocessor #7163

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7027

feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7027

vividf commented May 15, 2024 •

edited

Loading

vividf commented May 15, 2024

xmfcx commented May 15, 2024

xmfcx commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024 •

edited

Loading

vividf commented May 16, 2024

feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7027

feat(pointcloud_preprocessor): support 3d distortion corrector for distortion corrector node #7027

Conversation

vividf commented May 15, 2024 • edited Loading

Description

Related links

Tests performed

Time comparison

Pointcloud comparison

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

vividf commented May 15, 2024

xmfcx commented May 15, 2024

xmfcx commented May 15, 2024 • edited Loading

github-actions bot commented May 15, 2024 • edited Loading

vividf commented May 16, 2024

vividf commented May 15, 2024 •

edited

Loading

xmfcx commented May 15, 2024 •

edited

Loading

github-actions bot commented May 15, 2024 •

edited

Loading