-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bpp): remove unnecessary enable_module in sampling_planner #7038
base: main
Are you sure you want to change the base?
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. |
@mitsudome-r to rebase and merge this. |
@mitsudome-r ping. |
c8e2040
to
264d3ba
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@shmpwk It looks like the depending PR was closed. Is there a reason for it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7038 +/- ##
==========================================
- Coverage 29.43% 29.43% -0.01%
==========================================
Files 1417 1418 +1
Lines 107418 107430 +12
Branches 42561 42558 -3
==========================================
+ Hits 31620 31621 +1
- Misses 72722 72734 +12
+ Partials 3076 3075 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No, the depending PR was accidentally closed because that branch was deleted. |
@takayuki5168 could you please review this PR? |
Description
It seems
enable_module
is no longer used.Original PR: #6131
Depending PR: autowarefoundation/autoware_launch#990
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.