Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpp): remove unnecessary enable_module in sampling_planner #7038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented May 16, 2024

Description

It seems enable_module is no longer used.
Original PR: #6131
Depending PR: autowarefoundation/autoware_launch#990

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

stale bot commented Aug 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 20, 2024
@mitsudome-r
Copy link
Member

@mitsudome-r to rebase and merge this.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jan 21, 2025

@mitsudome-r ping.

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 21, 2025
@mitsudome-r
Copy link
Member

@shmpwk It looks like the depending PR was closed. Is there a reason for it?

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.43%. Comparing base (71f616d) to head (264d3ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7038      +/-   ##
==========================================
- Coverage   29.43%   29.43%   -0.01%     
==========================================
  Files        1417     1418       +1     
  Lines      107418   107430      +12     
  Branches    42561    42558       -3     
==========================================
+ Hits        31620    31621       +1     
- Misses      72722    72734      +12     
+ Partials     3076     3075       -1     
Flag Coverage Δ *Carryforward flag
differential 25.75% <ø> (?)
total 29.43% <ø> (+<0.01%) ⬆️ Carriedforward from 71f616d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk
Copy link
Contributor Author

shmpwk commented Jan 29, 2025

@mitsudome-r

It looks like the depending PR was closed. Is there a reason for it?

No, the depending PR was accidentally closed because that branch was deleted.
I recovered the depending PR: autowarefoundation/autoware_launch#1317
This PR is still ready to merge.

@danielsanchezaran
Copy link
Contributor

@takayuki5168 could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants