feat(pose_instability_detector): change validation algorithm #7042
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jun 7, 2024 in 42s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Large Method pose_instability_detector.cpp: PoseInstabilityDetector::clip_out_necessary_twist
- Bumpy Road Ahead pose_instability_detector.cpp: PoseInstabilityDetector::clip_out_necessary_twist
✅ Improving Code Health:
- Complex Method pose_instability_detector.cpp: PoseInstabilityDetector::callback_timer
Annotations
Check notice on line 178 in localization/pose_instability_detector/src/pose_instability_detector.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
PoseInstabilityDetector::callback_timer decreases in cyclomatic complexity from 11 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
PoseInstabilityDetector::clip_out_necessary_twist has 77 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
PoseInstabilityDetector::clip_out_necessary_twist has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading