Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(motion_velocity_smoother): remove string stream creation #7131

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented May 27, 2024

Description

Remove stringstream creation to improve performance

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 27, 2024
@rej55 rej55 force-pushed the chore/remove_string_stream_creation branch from c305ccd to b43ab84 Compare May 29, 2024 09:43
Signed-off-by: Fumiya Watanabe <[email protected]>
@rej55 rej55 force-pushed the chore/remove_string_stream_creation branch from b43ab84 to 8a87a6a Compare May 29, 2024 09:45
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 29, 2024
@rej55 rej55 merged commit c92185a into autowarefoundation:main May 31, 2024
33 of 35 checks passed
@rej55 rej55 deleted the chore/remove_string_stream_creation branch May 31, 2024 07:00
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…arefoundation#7131)

* chore(motion_velocity_smoother): remove string stream creation

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: use format string

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…arefoundation#7131)

* chore(motion_velocity_smoother): remove string stream creation

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: use format string

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* chore(motion_velocity_smoother): remove string stream creation

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: use format string

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants