-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(motion_velocity_smoother): remove string stream creation #7131
Merged
rej55
merged 2 commits into
autowarefoundation:main
from
rej55:chore/remove_string_stream_creation
May 31, 2024
Merged
chore(motion_velocity_smoother): remove string stream creation #7131
rej55
merged 2 commits into
autowarefoundation:main
from
rej55:chore/remove_string_stream_creation
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 27, 2024
3 tasks
maxime-clem
reviewed
May 27, 2024
...ocity_smoother/src/smoother/analytical_jerk_constrained_smoother/velocity_planning_utils.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Fumiya Watanabe <[email protected]>
rej55
force-pushed
the
chore/remove_string_stream_creation
branch
from
May 29, 2024 09:43
c305ccd
to
b43ab84
Compare
Signed-off-by: Fumiya Watanabe <[email protected]>
rej55
force-pushed
the
chore/remove_string_stream_creation
branch
from
May 29, 2024 09:45
b43ab84
to
8a87a6a
Compare
maxime-clem
approved these changes
May 29, 2024
maxime-clem
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 29, 2024
satoshi-ota
approved these changes
May 31, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…arefoundation#7131) * chore(motion_velocity_smoother): remove string stream creation Signed-off-by: Fumiya Watanabe <[email protected]> * fix: use format string Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…arefoundation#7131) * chore(motion_velocity_smoother): remove string stream creation Signed-off-by: Fumiya Watanabe <[email protected]> * fix: use format string Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* chore(motion_velocity_smoother): remove string stream creation Signed-off-by: Fumiya Watanabe <[email protected]> * fix: use format string Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
stringstream
creation to improve performanceTests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.