-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): apply new RTC state #7152
Merged
rej55
merged 5 commits into
autowarefoundation:main
from
rej55:feat/lane_change_rtc_state
May 31, 2024
Merged
feat(lane_change): apply new RTC state #7152
rej55
merged 5 commits into
autowarefoundation:main
from
rej55:feat/lane_change_rtc_state
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rej55
requested review from
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
May 28, 2024 09:52
rej55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
May 28, 2024
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 28, 2024
zulfaqar-azmi-t4
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rej55
force-pushed
the
feat/lane_change_rtc_state
branch
from
May 29, 2024 01:37
5cd827a
to
a831064
Compare
Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Fumiya Watanabe <[email protected]>
Signed-off-by: Fumiya Watanabe <[email protected]>
rej55
force-pushed
the
feat/lane_change_rtc_state
branch
from
May 29, 2024 08:27
8ce22af
to
d390482
Compare
Signed-off-by: Fumiya Watanabe <[email protected]>
kyoichi-sugahara
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* feat(lane_change): support for new RTC state transition Signed-off-by: Fumiya Watanabe <[email protected]> * fix: distance at aborting Signed-off-by: Fumiya Watanabe <[email protected]> * fix(lane_change): empty check Signed-off-by: Fumiya Watanabe <[email protected]> * fix(rtc_interface):update activation depends on RTC state Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
* feat(lane_change): support for new RTC state transition Signed-off-by: Fumiya Watanabe <[email protected]> * fix: distance at aborting Signed-off-by: Fumiya Watanabe <[email protected]> * fix(lane_change): empty check Signed-off-by: Fumiya Watanabe <[email protected]> * fix(rtc_interface):update activation depends on RTC state Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat(lane_change): support for new RTC state transition Signed-off-by: Fumiya Watanabe <[email protected]> * fix: distance at aborting Signed-off-by: Fumiya Watanabe <[email protected]> * fix(lane_change): empty check Signed-off-by: Fumiya Watanabe <[email protected]> * fix(rtc_interface):update activation depends on RTC state Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
go-sakayori
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 1, 2024
* feat(lane_change): support for new RTC state transition Signed-off-by: Fumiya Watanabe <[email protected]> * fix: distance at aborting Signed-off-by: Fumiya Watanabe <[email protected]> * fix(lane_change): empty check Signed-off-by: Fumiya Watanabe <[email protected]> * fix(rtc_interface):update activation depends on RTC state Signed-off-by: Fumiya Watanabe <[email protected]> --------- Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply new RTC state to lane change module.
In addition, fix the problem that lane change module does not calculate distance to start and finish when the module state is running.
Related links
Tests performed
TIER IV INTERNAL LINK
CANCEL
ABORT
Notes for reviewers
Interface changes
Not applicable.
ROS Topic Changes
Not applicable.
ROS Parameter Changes
Not applicable.
Effects on system behavior
New RTC state is applied in
/planning/cooperate_status/lane_change_**
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.