Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): apply new RTC state #7152

Merged
merged 5 commits into from
May 31, 2024

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented May 28, 2024

Description

Apply new RTC state to lane change module.
In addition, fix the problem that lane change module does not calculate distance to start and finish when the module state is running.

Related links

Tests performed

TIER IV INTERNAL LINK

CANCEL

vlcsnap-2024-05-28-18h32m59s167

ABORT

vlcsnap-2024-05-28-18h49m37s922

Notes for reviewers

Interface changes

Not applicable.

ROS Topic Changes

Not applicable.

ROS Parameter Changes

Not applicable.

Effects on system behavior

New RTC state is applied in /planning/cooperate_status/lane_change_**

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 28, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 28, 2024
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rej55 rej55 force-pushed the feat/lane_change_rtc_state branch from 5cd827a to a831064 Compare May 29, 2024 01:37
@rej55 rej55 force-pushed the feat/lane_change_rtc_state branch from 8ce22af to d390482 Compare May 29, 2024 08:27
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rej55 rej55 merged commit d5a6c54 into autowarefoundation:main May 31, 2024
23 of 24 checks passed
@rej55 rej55 deleted the feat/lane_change_rtc_state branch May 31, 2024 06:36
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat(lane_change): support for new RTC state transition

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: distance at aborting

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): empty check

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(rtc_interface):update activation depends on RTC state

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
* feat(lane_change): support for new RTC state transition

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: distance at aborting

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): empty check

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(rtc_interface):update activation depends on RTC state

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* feat(lane_change): support for new RTC state transition

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: distance at aborting

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): empty check

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(rtc_interface):update activation depends on RTC state

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
go-sakayori pushed a commit to tier4/autoware.universe that referenced this pull request Aug 1, 2024
* feat(lane_change): support for new RTC state transition

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix: distance at aborting

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(lane_change): empty check

Signed-off-by: Fumiya Watanabe <[email protected]>

* fix(rtc_interface):update activation depends on RTC state

Signed-off-by: Fumiya Watanabe <[email protected]>

---------

Signed-off-by: Fumiya Watanabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants