Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test_utils): move to common folder #7158

Merged

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented May 29, 2024

Description

Other component might benefit from using test_utils function, therefore this PR aims to move test_utils to common folder.
Also, added autoware prefix and namespace

Related links

None

Tests performed

Pass CI

Notes for reviewers

None

Interface changes

None

ROS Topic Changes

None

ROS Parameter Changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels May 29, 2024
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels May 29, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 force-pushed the RT1-6553-move-test-utils-to-common branch from cc137ba to 40f8097 Compare June 11, 2024 14:58
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) June 12, 2024 07:24
@mitsudome-r mitsudome-r disabled auto-merge June 12, 2024 07:55
@mitsudome-r mitsudome-r merged commit 2ca96d0 into autowarefoundation:main Jun 12, 2024
25 of 26 checks passed
@mitsudome-r mitsudome-r deleted the RT1-6553-move-test-utils-to-common branch June 12, 2024 07:55
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* Move autoware planning test manager to autoware namespace

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix package share directory for behavior path planner

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* renaming files and directory

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* rename variables that has planning_test_utils in its name.

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* use autoware namespace for test utils

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* move folder to common

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* update .pages file

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix test error

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* removed obstacle velocity limiter test artifact

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* remove namespace from planning validator, it has using keyword

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants