-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test_utils): move to common folder #7158
Merged
mitsudome-r
merged 10 commits into
autowarefoundation:main
from
tier4:RT1-6553-move-test-utils-to-common
Jun 12, 2024
Merged
refactor(test_utils): move to common folder #7158
mitsudome-r
merged 10 commits into
autowarefoundation:main
from
tier4:RT1-6553-move-test-utils-to-common
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
labels
May 29, 2024
zulfaqar-azmi-t4
added
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
labels
May 29, 2024
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7158/ |
zulfaqar-azmi-t4
force-pushed
the
RT1-6553-move-test-utils-to-common
branch
from
May 31, 2024 09:40
74d8207
to
271291b
Compare
zulfaqar-azmi-t4
requested review from
rej55,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
go-sakayori,
kosuke55,
soblin,
kyoichi-sugahara,
maxime-clem,
brkay54,
yuki-takagi-66,
mkuri,
TomohitoAndo and
ahmeddesokyebrahim
as code owners
May 31, 2024 09:40
zulfaqar-azmi-t4
force-pushed
the
RT1-6553-move-test-utils-to-common
branch
from
June 3, 2024 08:02
271291b
to
4080550
Compare
zulfaqar-azmi-t4
force-pushed
the
RT1-6553-move-test-utils-to-common
branch
from
June 11, 2024 10:14
4080550
to
89f819a
Compare
zulfaqar-azmi-t4
force-pushed
the
RT1-6553-move-test-utils-to-common
branch
from
June 11, 2024 12:44
89f819a
to
cc137ba
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
force-pushed
the
RT1-6553-move-test-utils-to-common
branch
from
June 11, 2024 14:58
cc137ba
to
40f8097
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
maxime-clem
reviewed
Jun 12, 2024
planning/obstacle_velocity_limiter/test/test_obstacle_velocity_limiter_node_interface.cpp
Outdated
Show resolved
Hide resolved
go-sakayori
reviewed
Jun 12, 2024
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
maxime-clem
approved these changes
Jun 12, 2024
kyoichi-sugahara
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
takayuki5168
approved these changes
Jun 12, 2024
rej55
approved these changes
Jun 12, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Move autoware planning test manager to autoware namespace Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix package share directory for behavior path planner Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * renaming files and directory Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * rename variables that has planning_test_utils in its name. Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * use autoware namespace for test utils Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * move folder to common Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * update .pages file Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * fix test error Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * removed obstacle velocity limiter test artifact Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> * remove namespace from planning validator, it has using keyword Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]> --------- Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other component might benefit from using
test_utils
function, therefore this PR aims to movetest_utils
tocommon
folder.Also, added autoware prefix and namespace
Related links
None
Tests performed
Pass CI
Notes for reviewers
None
Interface changes
None
ROS Topic Changes
None
ROS Parameter Changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.