fix(localization_error_monitor): fixed header stamp #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
added
the
run:build-and-test-differential
SakodaShintaro
requested review from
anhnv3991,
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:localization
YamatoAndo
approved these changes
May 30, 2024
SakodaShintaro
merged commit 365b5a8
into
autowarefoundation:main
32 of 34 checks passed
SakodaShintaro
deleted the
fix/fix_header_stamp_at_localization_error_monitor
branch
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…on#7174) Fixed header stamp at localization_error_monitor Signed-off-by: Shintaro Sakoda <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…on#7174) Fixed header stamp at localization_error_monitor Signed-off-by: Shintaro Sakoda <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
Fixed header stamp at localization_error_monitor Signed-off-by: Shintaro Sakoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
localization_error_monitoroutputs a timestamp in the diagnostic message header with the node'sthis->now()set. However, we are interested in the time when the message monitored by thelocalization_error_monitornode was published. So I changed the timestamp to be set, fromthis->now()toinput_msg->header.stamp.Tests performed
I ran logging_simulator and parsed the
/diagnosticstopic from the saved rosbag.I have confirmed that all timestamps in
localization: localization_error_monitorhave a match inlocalization: ekf_localizer.Effects on system behavior
There are no effects on system behavior.
Interface changes
There are no interface changes.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.