refactor(start_planner): improve readability of end condition #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
kyoichi-sugahara
requested review from
danielsanchezaran,
kosuke55,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
kyoichi-sugahara
added
the
run:build-and-test-differential
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
refactor/clarify_success_state
branch
from
0d87eb5 to
8fd8bd5
Compare
Signed-off-by: kyoichi-sugahara <[email protected]>
planning/behavior_path_start_planner_module/src/start_planner_module.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_start_planner_module/src/start_planner_module.cpp
Show resolved
Hide resolved
Signed-off-by: kyoichi-sugahara <[email protected]>
danielsanchezaran
approved these changes
May 31, 2024
kyoichi-sugahara
merged commit ba292be
into
autowarefoundation:main
25 of 26 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…refoundation#7181) * refactor(start_planner): clarify condition of transition to success Signed-off-by: kyoichi-sugahara <[email protected]> * modify flowchart Signed-off-by: kyoichi-sugahara <[email protected]> * add debug print Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…refoundation#7181) * refactor(start_planner): clarify condition of transition to success Signed-off-by: kyoichi-sugahara <[email protected]> * modify flowchart Signed-off-by: kyoichi-sugahara <[email protected]> * add debug print Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* refactor(start_planner): clarify condition of transition to success Signed-off-by: kyoichi-sugahara <[email protected]> * modify flowchart Signed-off-by: kyoichi-sugahara <[email protected]> * add debug print Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
canTransitSuccessStateupdated document
Tests performed
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.