-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace autoware_auto_msgs with autoware_msgs for launch files #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
zulfaqar-azmi-t4,
miursh,
YoshiRi and
yukkysaito
as code owners
June 3, 2024 15:45
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Jun 3, 2024
xmfcx
added
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
labels
Jun 4, 2024
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7242/ |
yukkysaito
reviewed
Jun 4, 2024
launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]>
…n/traffic_light.launch.xml
yukkysaito
force-pushed
the
autoware_msg_launch
branch
from
June 4, 2024 16:28
ef3b9be
to
0c952bf
Compare
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…autowarefoundation#7242) * feat!: replace autoware_auto_msgs with autoware_msgs for launch files Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]> * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml --------- Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…#7242) * feat!: replace autoware_auto_msgs with autoware_msgs for launch files Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]> * Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml --------- Signed-off-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Cynthia Liu <[email protected]> Co-authored-by: NorahXiong <[email protected]> Co-authored-by: beginningfan <[email protected]> Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is subset of #6893 to make it easier to review.
This includes all the modification for
launch
directory in the original PR.Related links
#6893
https://github.com/orgs/autowarefoundation/discussions/3862
Tests performed
Notes for reviewers
Interface changes
Message types are modified according to the table in this comment.
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.