Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace autoware_auto_msgs with autoware_msgs for launch files #7242

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

mitsudome-r
Copy link
Member

Description

This is subset of #6893 to make it easier to review.
This includes all the modification for launch directory in the original PR.

Related links

#6893
https://github.com/orgs/autowarefoundation/discussions/3862

Tests performed

Notes for reviewers

Interface changes

Message types are modified according to the table in this comment.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jun 3, 2024
@xmfcx xmfcx added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7242/
Modified URLs:

mitsudome-r and others added 2 commits June 5, 2024 01:28
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
@yukkysaito yukkysaito force-pushed the autoware_msg_launch branch from ef3b9be to 0c952bf Compare June 4, 2024 16:28
@yukkysaito yukkysaito merged commit 5c1266e into main Jun 4, 2024
13 of 14 checks passed
@yukkysaito yukkysaito deleted the autoware_msg_launch branch June 4, 2024 16:29
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…autowarefoundation#7242)

* feat!: replace autoware_auto_msgs with autoware_msgs for launch files

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

---------

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…#7242)

* feat!: replace autoware_auto_msgs with autoware_msgs for launch files

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>

* Update launch/tier4_perception_launch/launch/traffic_light_recognition/traffic_light.launch.xml

---------

Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Cynthia Liu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: beginningfan <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants