-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accel_brake_map_calibrator): replace polling takeData function with the callback function #7282
Closed
N-Eiki
wants to merge
85
commits into
autowarefoundation:main
from
N-Eiki:feat/use_takeData_in_abc_module
Closed
feat(accel_brake_map_calibrator): replace polling takeData function with the callback function #7282
N-Eiki
wants to merge
85
commits into
autowarefoundation:main
from
N-Eiki:feat/use_takeData_in_abc_module
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
…lain. change function name callback to take. Signed-off-by: N-Eiki <[email protected]>
N-Eiki
requested review from
taikitanaka3,
1222-takeshi and
tkimura4
as code owners
June 5, 2024 10:47
github-actions
bot
added
the
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
label
Jun 5, 2024
tkimura4
reviewed
Jun 5, 2024
..._brake_map_calibrator/include/accel_brake_map_calibrator/accel_brake_map_calibrator_node.hpp
Outdated
Show resolved
Hide resolved
tkimura4
reviewed
Jun 5, 2024
..._brake_map_calibrator/include/accel_brake_map_calibrator/accel_brake_map_calibrator_node.hpp
Outdated
Show resolved
Hide resolved
tkimura4
reviewed
Jun 5, 2024
..._brake_map_calibrator/include/accel_brake_map_calibrator/accel_brake_map_calibrator_node.hpp
Outdated
Show resolved
Hide resolved
N-Eiki
changed the title
Feat/use take data in abc module
feat(external_cmd_converter): replace polling takeData function with the callback function #7263
Jun 5, 2024
N-Eiki
changed the title
feat(external_cmd_converter): replace polling takeData function with the callback function #7263
feat(accel_brake_map_calibrator): replace polling takeData function with the callback function
Jun 5, 2024
shmpwk
reviewed
Jun 5, 2024
…uto msg Signed-off-by: N-Eiki <[email protected]>
…sis.\n handle new msg Signed-off-by: N-Eiki <[email protected]>
…nupdate mailadress. Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
Signed-off-by: N-Eiki <[email protected]>
N-Eiki
requested review from
danielsanchezaran,
zulfaqar-azmi-t4,
technolojin,
ktro2828,
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto and
SakodaShintaro
as code owners
June 11, 2024 02:26
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:system
System design and integration. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
labels
Jun 11, 2024
N-Eiki
removed request for
zusizusi,
shmpwk,
1222-takeshi,
tkimura4,
shtokuda and
takayuki5168
June 11, 2024 02:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
component:system
System design and integration. (auto-assigned)
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, instead of getting msg in callback, it is changed to get msg using takeData function of polling_subscriber in utils.
Related links
Tests performed
The module works as before. By the way, I only have a rosbag file that was collected with the old messages (autoware_auto_* msgs). I don't have any rosbag files with the new messages (autoware_* msgs). So, I confirmed with the old rosbag file and replaced the messages later.
before with old msg
abc_before.mp4
after with old msg
abc_after.mp4
Notes for reviewers
Interface changes
none
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.