Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accel_brake_map_calibrator): replace polling takeData function with the callback function #7282

Closed

Conversation

N-Eiki
Copy link
Contributor

@N-Eiki N-Eiki commented Jun 5, 2024

Description

In this PR, instead of getting msg in callback, it is changed to get msg using takeData function of polling_subscriber in utils.

Related links

Tests performed

// terminal1
ros2 launch accel_brake_map_calibrator accel_brake_map_calibrator.launch.xml rviz:=true use_sim_time:=true

// terminal2
ros2 bag play <rosbag file> --clock

The module works as before. By the way, I only have a rosbag file that was collected with the old messages (autoware_auto_* msgs). I don't have any rosbag files with the new messages (autoware_* msgs). So, I confirmed with the old rosbag file and replaced the messages later.

before with old msg

abc_before.mp4

after with old msg

abc_after.mp4

Notes for reviewers

Interface changes

none

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@N-Eiki N-Eiki requested review from takayuki5168 and shmpwk June 5, 2024 10:47
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Jun 5, 2024
@N-Eiki N-Eiki changed the title Feat/use take data in abc module feat(external_cmd_converter): replace polling takeData function with the callback function #7263 Jun 5, 2024
@N-Eiki N-Eiki changed the title feat(external_cmd_converter): replace polling takeData function with the callback function #7263 feat(accel_brake_map_calibrator): replace polling takeData function with the callback function Jun 5, 2024
@shmpwk shmpwk requested review from zusizusi and shtokuda June 5, 2024 11:18
@N-Eiki N-Eiki marked this pull request as draft June 5, 2024 11:27
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jun 11, 2024
@N-Eiki N-Eiki marked this pull request as draft June 11, 2024 02:29
@N-Eiki N-Eiki closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.