Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_side_shift_module)!: prefix package and namespace with autoware #7326

Merged

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jun 6, 2024

Description

rename package to autoware_behavior_path_side_shift_module from behavior_path_side_shift_module.

Part of:

Tests performed

run psim and confirmed side shift module is working appropriately
Screenshot from 2024-06-06 21-12-15

enabled with following command

ros2 topic pub /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/input/lateral_offset tier4_planning_msgs/msg/LateralOffset "{stamp: {sec: $(date +%s), nanosec: $(date +%N)}, lateral_offset: 1.5}" -1

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 6, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title chore(side_shift_module): add prefix autoware_ to side_shift refactor(behavior_path_side_shift_module)!: prefix package and namespace with autoware Jun 6, 2024
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara merged commit 17aad93 into autowarefoundation:main Jun 7, 2024
23 of 24 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the prefix-side_shift branch June 7, 2024 02:41
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ace with autoware (#7326)

* add prefix autoware_ to side_shift package

Signed-off-by: kyoichi-sugahara <[email protected]>

* change directory name

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants