Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vehicle_info_utils)!: prefix package and namespace with autoware #7353

Merged
merged 33 commits into from
Jun 10, 2024

fix(autoware_joy_controller): remove unused deps

1ded88f
Select commit
Loading
Failed to load commit list.
Merged

refactor(vehicle_info_utils)!: prefix package and namespace with autoware #7353

fix(autoware_joy_controller): remove unused deps
1ded88f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 10, 2024 in 1m 28s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Absence of Expected Change Pattern

  • autoware.universe/planning/behavior_velocity_no_stopping_area_module/src/manager.cpp is usually changed with: autoware.universe/planning/behavior_velocity_detection_area_module/src/manager.cpp

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method pid_longitudinal_controller.cpp: diagnostic_updater_ 🔥

Annotations

Check warning on line 45 in control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

diagnostic_updater_ increases from 136 to 138 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis