-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_universe_utils)!: rename from tier4_autoware_utils #7538
feat(autoware_universe_utils)!: rename from tier4_autoware_utils #7538
Conversation
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: kosuke55 <[email protected]>
638ec35
to
63e6f84
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7538 +/- ##
===========================================
+ Coverage 14.84% 28.37% +13.53%
===========================================
Files 1999 1419 -580
Lines 139163 104737 -34426
Branches 43716 45338 +1622
===========================================
+ Hits 20661 29723 +9062
+ Misses 95731 66697 -29034
+ Partials 22771 8317 -14454
☔ View full report in Codecov by Sentry. |
The change seems to be quite large. They seems to be just simple replacement of namespace, but have you tested with any PSim/LSim so that Autoware launches without an error? |
…niverse_utils caused by the following issues and pull requests: * autowarefoundation/autoware.universe#7538 * https://github.com/orgs/autowarefoundation/discussions/4881 * https://github.com/orgs/autowarefoundation/discussions/4855
…niverse_utils caused by the following issues and pull requests: * autowarefoundation/autoware.universe#7538 * https://github.com/orgs/autowarefoundation/discussions/4881 * https://github.com/orgs/autowarefoundation/discussions/4855. Fixed namespace.
…owarefoundation#7538) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: kosuke55 <[email protected]> Co-authored-by: kosuke55 <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: kosuke55 <[email protected]> Co-authored-by: kosuke55 <[email protected]>
Description
find ./ -type f -exec sed -i -e 's/tier4_autoware_utils/autoware_universe_utils/g' {} \;
tier4_autoware_utils
directory toautoware_universe_utils
.https://github.com/orgs/autowarefoundation/discussions/4881
We apologize for the trouble regarding autoware_ prefix support for Planning/Control and appreciate your cooperation.
Thanks to your help, we are almost done with the individual node support.
As a final step, we are going to create a PR with significant changes, and we would like to inform you of them.
By this PR, We will change as
Although this PR contains many code changes, including a change to almost all nodes in planning/control, we plan to merge the change by a single PR for simplicity and to avoid conflicts and work-in-progress problems.
We will proceed with the utmost care so as not to bring any defects to the main branch, and we appreciate your understanding and cooperation.
Related PR:
autowarefoundation/autoware_tools#52
part of autowarefoundation/autoware#4569
Tests performed
clean build all pacakges and psim/lsim
evaluator
https://evaluation.tier4.jp/evaluation/reports/2fa4d6f6-6ea2-5678-be51-bc85601dc37e?project_id=prd_jt
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.