Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure ament_package() is called when CUDA is not found #7917

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: make sure ament_package() is called when CUDA is not found #7917

wants to merge 1 commit into from
+2 −0

Conversation

mitsudome-r
Copy link
Member

Description

Resolves #7916

Related links

How was this PR tested?

Install Autoware on machines without CUDA installed and run source install/setup.bash

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

mitsudome-r
mitsudome-r commented Jul 9, 2024
View reviewed changes
common/tensorrt_common/CMakeLists.txt
@@ -13,6 +13,7 @@ find_package(TENSORRT)

if(NOT (CUDAToolkit_FOUND AND CUDNN_FOUND AND TENSORRT_FOUND))
message(WARNING "cuda, cudnn, tensorrt libraries are not found")
ament_package()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using ament_package() instead of ament_auto_packages() to match with L82 in the original file.

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.44%. Comparing base (f716b5b) to head (79bb10d).
Report is 990 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7917      +/-   ##
==========================================
+ Coverage   28.42%   28.44%   +0.01%     
==========================================
  Files        1591     1591              
  Lines      116213   116224      +11     
  Branches    49606    49618      +12     
==========================================
+ Hits        33039    33059      +20     
+ Misses      74174    74143      -31     
- Partials     9000     9022      +22
Flag Coverage Δ *Carryforward flag
differential 5.45% <ø> (?)
total 28.44% <ø> (+0.01%) ⬆️ Carriedforward from 458dbe5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r marked this pull request as draft July 9, 2024 09:15
@mitsudome-r
Copy link
Member Author

It looks like some packages (like lidar_apollo_instance_segmentation) uses if(NOT ${tensorrt_common_FOUND}) and causes failure with this change. I will think about some solutions to fix this issue in more clean way.

@stale Stale
Copy link

stale bot commented Oct 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktro2828 ktro2828 Awaiting requested review from ktro2828

@miursh miursh Awaiting requested review from miursh

@dan-dnn dan-dnn Awaiting requested review from dan-dnn

@manato manato Awaiting requested review from manato

At least 1 approving review is required to merge this pull request.

Assignees

@mitsudome-r mitsudome-r

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running source/install/setup.bash complains that it cannot find "local_setup.bash" for some packages
1 participant
@mitsudome-r