refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.00 (8.02 -> 8.02)
- Improving Code Health: 3 findings(s) ✅
Details
✅ Improving Code Health:
- Complex Method filter.cpp: pointcloud_preprocessor::Filter::faster_input_indices_callback
- Complex Method filter.cpp: pointcloud_preprocessor::Filter::input_indices_callback
- Bumpy Road Ahead filter.cpp: pointcloud_preprocessor::Filter::convert_output_costly
Annotations
Check notice on line 415 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
pointcloud_preprocessor::Filter::faster_input_indices_callback is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 228 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
pointcloud_preprocessor::Filter::input_indices_callback is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 415 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
autoware::pointcloud_preprocessor::Filter::faster_input_indices_callback has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 228 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Complex Method
autoware::pointcloud_preprocessor::Filter::input_indices_callback has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 367 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
pointcloud_preprocessor::Filter::convert_output_costly is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 367 in sensing/autoware_pointcloud_preprocessor/src/filter.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Bumpy Road Ahead
autoware::pointcloud_preprocessor::Filter::convert_output_costly has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.