refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983

amadeuszsz · 2024-07-11T12:13:18Z

Description

Most of packages applies pointcloud_preprocessor plugin, therefore splitting PR for namespace and package prefix won't help with omitting breaking change.

How was this PR tested?

Planning simulator & logging simulator

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… autoware Signed-off-by: Amadeusz Szymko <[email protected]>

github-actions · 2024-07-11T12:13:35Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

Signed-off-by: Amadeusz Szymko <[email protected]>

codecov · 2024-07-12T01:41:00Z

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (c4d75b3) to head (3e0099a).
Report is 9 commits behind head on main.

Files	Patch %	Lines
...ng/autoware_pointcloud_preprocessor/src/filter.cpp	53.84%	6 Missing ⚠️
...eprocessor/src/polygon_remover/polygon_remover.cpp	33.33%	2 Missing ⚠️
...ector_map_filter/vector_map_inside_area_filter.cpp	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7983      +/-   ##
==========================================
- Coverage   29.11%   28.63%   -0.49%     
==========================================
  Files        1610     1659      +49     
  Lines      118127   121155    +3028     
  Branches    50852    52376    +1524     
==========================================
+ Hits        34396    34694     +298     
- Misses      74564    77291    +2727     
- Partials     9167     9170       +3

Flag	Coverage Δ		*Carryforward flag
differential	`12.21% <77.27%> (?)`
total	`28.89% <ø> (-0.23%)`	⬇️	Carriedforward from da811d1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Amadeusz Szymko <[email protected]>

amadeuszsz · 2024-07-12T05:49:05Z

@amadeuszsz Could not leave a message, but src/autoware/universe/sensing/autoware_pointcloud_preprocessor/launch/preprocessor.launch.xml seems to be missing a prefix

34c2e48

…refix

knzo25

LGTM 🎉

amadeuszsz · 2024-07-16T03:15:16Z

Friendly ping for package maintainers:

@tkimura4 - control/autoware_autonomous_emergency_braking, launch/tier4_planning_launch
@SakodaShintaro - launch/tier4_localization_launch

tkimura4

LGTM

SakodaShintaro · 2024-07-16T04:26:44Z

@amadeuszsz
Thank you very much. LGTM for launch/tier4_localization_launch

This is outside the scope of my review, but I have one comment.
According to the documentation, the recommended directory structure is autoware_{name}/include/autoware/{name}, but in this pull request, it seems to be autoware_pointcloud_preprocessor/include/autoware_pointcloud_preprocessor. Is this intentional?

amadeuszsz · 2024-07-16T04:48:18Z

@amadeuszsz Thank you very much. LGTM for launch/tier4_localization_launch

This is outside the scope of my review, but I have one comment. According to the documentation, the recommended directory structure is autoware_{name}/include/autoware/{name}, but in this pull request, it seems to be autoware_pointcloud_preprocessor/include/autoware_pointcloud_preprocessor. Is this intentional?

@SakodaShintaro thanks four your review and comment.
I've seen other PRs which were accepted under same directory structure convention (e.g. #7892), thus I assumed there is no difference.
@technolojin could you please share your opinion here? If it's needed to follow autoware_{name}/include/autoware/{name} convention, I will do necessary changes.

Signed-off-by: Amadeusz Szymko <[email protected]>

…refix

amadeuszsz · 2024-07-19T05:21:39Z

@knzo25 @SakodaShintaro
I did changes with reference to directory structure. Renaming will make commits non-trackable, therefore I did two commits:

soft - code changes
hard - only changed directory structure from include/autoware_pointcloud_preprocessor to include/autoware/pointcloud_preprocessor

amadeuszsz · 2024-07-19T07:29:30Z

@YoshiRi @badai-nguyen may I ask you for review remaining packages?

@YoshiRi - launch/tier4_perception_launch, perception/ground_segmentation, perception/occupancy_grid_map_outlier_filter, perception/probabilistic_occupancy_grid_map
@badai-nguyen - perception/compare_map_segmentation, perception/euclidean_cluster, perception/ground_segmentation

badai-nguyen

LGTM regarding ground_segmentation, compare_map_segmentation, euclidean_cluster

…refix

technolojin · 2024-07-22T00:52:06Z

@amadeuszsz

@technolojin could you please share your opinion here? If it's needed to follow autoware_{name}/include/autoware/{name} convention, I will do necessary changes.

I am sorry for late response. It looks already done right.

technolojin

In terms of tier4_perception_launch, LGTM

YoshiRi

LGTM

…refix

…autoware (autowarefoundation#7983) * refactor(pointcloud_preprocessor)!: prefix package and namespace with autoware Signed-off-by: Amadeusz Szymko <[email protected]> * style(pre-commit): autofix * style(pointcloud_preprocessor): suppress line length check for macros Signed-off-by: Amadeusz Szymko <[email protected]> * fix(pointcloud_preprocessor): missing prefix Signed-off-by: Amadeusz Szymko <[email protected]> * fix(pointcloud_preprocessor): missing prefix Signed-off-by: Amadeusz Szymko <[email protected]> * fix(pointcloud_preprocessor): missing prefix Signed-off-by: Amadeusz Szymko <[email protected]> * fix(pointcloud_preprocessor): missing prefix Signed-off-by: Amadeusz Szymko <[email protected]> * fix(pointcloud_preprocessor): missing prefix Signed-off-by: Amadeusz Szymko <[email protected]> * refactor(pointcloud_preprocessor): directory structure (soft) Signed-off-by: Amadeusz Szymko <[email protected]> * refactor(pointcloud_preprocessor): directory structure (hard) Signed-off-by: Amadeusz Szymko <[email protected]> --------- Signed-off-by: Amadeusz Szymko <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>

refactor(pointcloud_preprocessor)!: prefix package and namespace with…

c6c93c4

… autoware Signed-off-by: Amadeusz Szymko <[email protected]>

style(pre-commit): autofix

d208e9e

style(pointcloud_preprocessor): suppress line length check for macros

1f0f238

Signed-off-by: Amadeusz Szymko <[email protected]>

amadeuszsz changed the title ~~refactor(pointcloud_preprocessor)!: prefix package and namespace with autoware~~ refactor(pointcloud_preprocessor): prefix package and namespace with autoware Jul 11, 2024

amadeuszsz mentioned this pull request Jul 12, 2024

refactor: pointcloud_preprocessor prefix package and namespace with autoware tier4/awsim_sensor_kit_launch#15

Merged

amadeuszsz added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 12, 2024

amadeuszsz marked this pull request as ready for review July 12, 2024 03:07

amadeuszsz requested review from amc-nu, badai-nguyen, drwnz, knzo25, kyoichi-sugahara, meliketanrikulu, miursh, vividf, YoshiRi, yukkysaito, soblin and rej55 as code owners July 12, 2024 03:07

amadeuszsz added 4 commits July 12, 2024 14:41

fix(pointcloud_preprocessor): missing prefix

3eac205

Signed-off-by: Amadeusz Szymko <[email protected]>

fix(pointcloud_preprocessor): missing prefix

77d9a06

Signed-off-by: Amadeusz Szymko <[email protected]>

fix(pointcloud_preprocessor): missing prefix

e19937d

Signed-off-by: Amadeusz Szymko <[email protected]>

fix(pointcloud_preprocessor): missing prefix

34c2e48

Signed-off-by: Amadeusz Szymko <[email protected]>

Merge branch 'main' into refactor/pointcloud_preprocessor-namespace-p…

1a15582

…refix

knzo25 approved these changes Jul 12, 2024

View reviewed changes

tkimura4 approved these changes Jul 16, 2024

View reviewed changes

SakodaShintaro approved these changes Jul 16, 2024

View reviewed changes

amadeuszsz added 2 commits July 19, 2024 13:25

refactor(pointcloud_preprocessor): directory structure (soft)

a07a2a9

Signed-off-by: Amadeusz Szymko <[email protected]>

refactor(pointcloud_preprocessor): directory structure (hard)

f587988

Signed-off-by: Amadeusz Szymko <[email protected]>

amadeuszsz requested a review from technolojin as a code owner July 19, 2024 05:13

Merge branch 'main' into refactor/pointcloud_preprocessor-namespace-p…

2e9ef35

…refix

badai-nguyen approved these changes Jul 19, 2024

View reviewed changes

Merge branch 'main' into refactor/pointcloud_preprocessor-namespace-p…

da811d1

…refix

technolojin approved these changes Jul 22, 2024

View reviewed changes

YoshiRi approved these changes Jul 22, 2024

View reviewed changes

amadeuszsz added 2 commits July 22, 2024 14:12

Merge branch 'main' into refactor/pointcloud_preprocessor-namespace-p…

01b39e7

…refix

Merge branch 'main' into refactor/pointcloud_preprocessor-namespace-p…

3e0099a

…refix

technolojin merged commit 9bb228f into autowarefoundation:main Jul 22, 2024
27 of 30 checks passed

softyanija mentioned this pull request Oct 16, 2024

fix: add autoware_ prefix to pointcloud_preprocessor autowarefoundation/autoware-documentation#620

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983

refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983

amadeuszsz commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

amadeuszsz commented Jul 12, 2024

knzo25 left a comment

amadeuszsz commented Jul 16, 2024 •

edited

Loading

tkimura4 left a comment

SakodaShintaro commented Jul 16, 2024

amadeuszsz commented Jul 16, 2024

amadeuszsz commented Jul 19, 2024

amadeuszsz commented Jul 19, 2024

badai-nguyen left a comment

technolojin commented Jul 22, 2024

technolojin left a comment

YoshiRi left a comment

refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983

refactor(pointcloud_preprocessor): prefix package and namespace with autoware #7983

Conversation

amadeuszsz commented Jul 11, 2024 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Jul 11, 2024 • edited Loading

codecov bot commented Jul 12, 2024 • edited Loading

Codecov Report

amadeuszsz commented Jul 12, 2024

knzo25 left a comment

Choose a reason for hiding this comment

amadeuszsz commented Jul 16, 2024 • edited Loading

tkimura4 left a comment

Choose a reason for hiding this comment

SakodaShintaro commented Jul 16, 2024

amadeuszsz commented Jul 16, 2024

amadeuszsz commented Jul 19, 2024

amadeuszsz commented Jul 19, 2024

badai-nguyen left a comment

Choose a reason for hiding this comment

technolojin commented Jul 22, 2024

technolojin left a comment

Choose a reason for hiding this comment

YoshiRi left a comment

Choose a reason for hiding this comment

amadeuszsz commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 12, 2024 •

edited

Loading

amadeuszsz commented Jul 16, 2024 •

edited

Loading