-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tensorrt_yolox)!: fix namespace and directory structure #7992
refactor(tensorrt_yolox)!: fix namespace and directory structure #7992
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
de56e97
to
f2b368f
Compare
5389a66
to
f07dad9
Compare
@badai-nguyen I updated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7992 +/- ##
==========================================
- Coverage 29.23% 28.96% -0.27%
==========================================
Files 1596 1603 +7
Lines 117709 118802 +1093
Branches 50709 50867 +158
==========================================
Hits 34415 34415
- Misses 74104 75197 +1093
Partials 9190 9190
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ktro2828 Thank you for your fixing.
|
080c5ae
to
bbce2bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran object detection and traffic light recognition to make sure the output is correct in local env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktro2828 @badai-nguyen @MasatoSaeki
I highly appreciate your help with this fixing. LGTM!
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
98679f8
to
959d59f
Compare
@Shin-kyoto @miursh @tzhong518 Could you review this? (I need at least 1 approve from the maintainer of |
…owarefoundation#7992) * refactor: add autoware namespace prefix to `tensorrt_yolox` Signed-off-by: ktro2828 <[email protected]> * refactor: apply `autoware` namespace to tensorrt_yolox Signed-off-by: ktro2828 <[email protected]> * chore: update CODEOWNERS Signed-off-by: ktro2828 <[email protected]> * fix: resolve `yolox_tiny` to work Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…owarefoundation#7992) * refactor: add autoware namespace prefix to `tensorrt_yolox` Signed-off-by: ktro2828 <[email protected]> * refactor: apply `autoware` namespace to tensorrt_yolox Signed-off-by: ktro2828 <[email protected]> * chore: update CODEOWNERS Signed-off-by: ktro2828 <[email protected]> * fix: resolve `yolox_tiny` to work Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
…owarefoundation#7992) * refactor: add autoware namespace prefix to `tensorrt_yolox` Signed-off-by: ktro2828 <[email protected]> * refactor: apply `autoware` namespace to tensorrt_yolox Signed-off-by: ktro2828 <[email protected]> * chore: update CODEOWNERS Signed-off-by: ktro2828 <[email protected]> * fix: resolve `yolox_tiny` to work Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>
Description
This PR puts headers in the
autoware
namespace.Additional works:
Related links
Parent Issue:
How was this PR tested?
I tested with the following launchers:
ros2 launch autoware_tensorrt_yolox yolox.launch.xml
ros2 launch autoware_tensorrt_yolox yolox_tiny.launch.xml
Notes for reviewers
This PR effects to the other repositories as follows:
autoware
prefix totensorrt_yolox
tier4/edge_auto_jetson_launch#13Interface changes
None.
Effects on system behavior
None.