-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vehicle_velocity_converter)!: prefix package and namespace with autoware #8967
refactor(vehicle_velocity_converter)!: prefix package and namespace with autoware #8967
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KeisukeShima @taikitanaka3 @TakaHoribe @takayuki5168 @tkimura4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8967 +/- ##
==========================================
- Coverage 29.60% 29.59% -0.01%
==========================================
Files 1442 1444 +2
Lines 108516 108545 +29
Branches 41406 41408 +2
==========================================
+ Hits 32122 32123 +1
- Misses 73268 73297 +29
+ Partials 3126 3125 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
@a-maumau Ready to merge?! |
@shmpwk |
@shmpwk sorry, could you wait a moment? seems some of repo. ( like https://github.com/autowarefoundation/single_lidar_sensor_kit_launch) also needs to be fixed. |
I created a PR to single_lidar_sensor_kit_launch, awsim_labs_sensor_kit_launch, and awsim_sensor_kit_launch After the review of these PRs, it should be OK this time. |
@a-maumau Thank you so much! Let's merge all PRs. |
@a-maumau |
…vehicle_velocity_converter
@shmpwk I have fixed the conflict! |
Thank you so much! |
Description
This PR will add the autoware prefix to
vehicle_velocity_converter
package.Related links
Related PRs
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.