Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vehicle_velocity_converter)!: prefix package and namespace with autoware #8967

Conversation

Signed-off-by: a-maumau <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:require-cuda-build-and-test labels Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 27, 2024
@YamatoAndo
Copy link
Contributor

@KeisukeShima @taikitanaka3 @TakaHoribe @takayuki5168 @tkimura4
Please review this pr.

@YamatoAndo YamatoAndo added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Oct 1, 2024
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.59%. Comparing base (3231bbf) to head (d805647).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ocity_converter/src/vehicle_velocity_converter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8967      +/-   ##
==========================================
- Coverage   29.60%   29.59%   -0.01%     
==========================================
  Files        1442     1444       +2     
  Lines      108516   108545      +29     
  Branches    41406    41408       +2     
==========================================
+ Hits        32122    32123       +1     
- Misses      73268    73297      +29     
+ Partials     3126     3125       -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.60% <ø> (+<0.01%) ⬆️ Carriedforward from 63cfff8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: a-maumau <[email protected]>
Signed-off-by: a-maumau <[email protected]>
@shmpwk
Copy link
Contributor

shmpwk commented Nov 25, 2024

@a-maumau Ready to merge?!

@a-maumau
Copy link
Contributor Author

a-maumau commented Nov 25, 2024

@shmpwk all related PR is approved so if there is no further suggestion, it should be OK.

@a-maumau
Copy link
Contributor Author

a-maumau commented Nov 25, 2024

@shmpwk sorry, could you wait a moment? seems some of repo. ( like https://github.com/autowarefoundation/single_lidar_sensor_kit_launch) also needs to be fixed.

@a-maumau
Copy link
Contributor Author

a-maumau commented Nov 25, 2024

I created a PR to single_lidar_sensor_kit_launch, awsim_labs_sensor_kit_launch, and awsim_sensor_kit_launch

After the review of these PRs, it should be OK this time.
(The core part is already reviewed, we might not need to wait for these 3 PRs?)

@shmpwk
Copy link
Contributor

shmpwk commented Nov 28, 2024

@a-maumau Thank you so much! Let's merge all PRs.

@shmpwk
Copy link
Contributor

shmpwk commented Dec 6, 2024

@a-maumau
Srr, could you resolve conflicts?

@a-maumau
Copy link
Contributor Author

a-maumau commented Dec 6, 2024

@shmpwk I have fixed the conflict!

@shmpwk shmpwk enabled auto-merge (squash) December 6, 2024 04:38
@shmpwk
Copy link
Contributor

shmpwk commented Dec 6, 2024

Thank you so much!

@shmpwk shmpwk merged commit 0bbdbe1 into autowarefoundation:main Dec 6, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants