New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_diag_publisher): not use diagnostic_updater and param callback #9257

Merged

ito-san merged 2 commits into autowarefoundation:main from tier4:takagi/dummy_diag/chery-pick-fix

Nov 8, 2024

Merged

fix(dummy_diag_publisher): not use diagnostic_updater and param callback #9257

fix: resolve build error of dummy diag publisher (#1415)

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 7, 2024 in 43s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.31 (9.69 -> 10.00)

Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

Bumpy Road Ahead dummy_diag_publisher_core.cpp: DummyDiagPublisher::paramCallback
Bumpy Road Ahead dummy_diag_publisher_core.cpp: DummyDiagPublisher::updateDiag

Annotations

Check notice on line 33 in system/dummy_diag_publisher/src/dummy_diag_publisher_core.cpp

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Bumpy Road Ahead

DummyDiagPublisher::paramCallback is no longer above the threshold for logical blocks with deeply nested code

Check notice on line 33 in system/dummy_diag_publisher/src/dummy_diag_publisher_core.cpp

codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Bumpy Road Ahead

DummyDiagPublisher::updateDiag is no longer above the threshold for logical blocks with deeply nested code

View more details on CodeScene Delta Analysis