Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): outputs velocity factor when the ego follows front vehicle. #9359

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 18, 2024

Description

I fixed logic so that this planner outputs velocity factor during adaptive cruising.

⚠️ Please merge following PR at first. (NOTE: I added new planning behavior in order to distinguish adaptive cruise behavior from obstacle stop.)

movie-2024-11-18_17.56.03.mp4

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: satoshi-ota <[email protected]>
@satoshi-ota satoshi-ota force-pushed the feat/output-velocity-factor-acc branch from 777ef60 to 606f988 Compare November 21, 2024 02:16
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 30.06%. Comparing base (1c96aa6) to head (606f988).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ing/autoware_obstacle_cruise_planner/src/utils.cpp 30.76% 8 Missing and 1 partial ⚠️
..._obstacle_cruise_planner/src/planner_interface.cpp 50.00% 2 Missing ⚠️
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9359      +/-   ##
==========================================
+ Coverage   28.95%   30.06%   +1.10%     
==========================================
  Files        1426     1341      -85     
  Lines      108249   103675    -4574     
  Branches    41397    40362    -1035     
==========================================
- Hits        31346    31169     -177     
+ Misses      73869    69497    -4372     
+ Partials     3034     3009      -25     
Flag Coverage Δ *Carryforward flag
differential 13.00% <33.33%> (?)
total 30.06% <ø> (+1.11%) ⬆️ Carriedforward from d17ffd3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@satoshi-ota satoshi-ota merged commit 0b72239 into autowarefoundation:main Nov 21, 2024
30 of 32 checks passed
@satoshi-ota satoshi-ota deleted the feat/output-velocity-factor-acc branch November 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants