-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_lidar_centerpoint): added the cuda_blackboard to centerpoint #9453
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,9 +108,10 @@ | |
detector_ptr_ = | ||
std::make_unique<CenterPointTRT>(encoder_param, head_param, densification_param, config); | ||
|
||
pointcloud_sub_ = this->create_subscription<sensor_msgs::msg::PointCloud2>( | ||
"~/input/pointcloud", rclcpp::SensorDataQoS{}.keep_last(1), | ||
std::bind(&LidarCenterPointNode::pointCloudCallback, this, std::placeholders::_1)); | ||
pointcloud_sub_ = | ||
std::make_unique<cuda_blackboard::CudaBlackboardSubscriber<cuda_blackboard::CudaPointCloud2>>( | ||
*this, "~/input/pointcloud", false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would you write a documentation for |
||
std::bind(&LidarCenterPointNode::pointCloudCallback, this, std::placeholders::_1)); | ||
Check warning on line 114 in perception/autoware_lidar_centerpoint/src/node.cpp CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)❌ Getting worse: Large Method
|
||
objects_pub_ = this->create_publisher<autoware_perception_msgs::msg::DetectedObjects>( | ||
"~/output/objects", rclcpp::QoS{1}); | ||
|
||
|
@@ -133,7 +134,7 @@ | |
} | ||
|
||
void LidarCenterPointNode::pointCloudCallback( | ||
const sensor_msgs::msg::PointCloud2::ConstSharedPtr input_pointcloud_msg) | ||
const std::shared_ptr<const cuda_blackboard::CudaPointCloud2> & input_pointcloud_msg) | ||
{ | ||
const auto objects_sub_count = | ||
objects_pub_->get_subscription_count() + objects_pub_->get_intra_process_subscription_count(); | ||
|
@@ -146,7 +147,7 @@ | |
} | ||
|
||
std::vector<Box3D> det_boxes3d; | ||
bool is_success = detector_ptr_->detect(*input_pointcloud_msg, tf_buffer_, det_boxes3d); | ||
bool is_success = detector_ptr_->detect(input_pointcloud_msg, tf_buffer_, det_boxes3d); | ||
if (!is_success) { | ||
return; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also perform voxel size validation?