refactor(autoware_autonomous_emergency_braking): update longitudinal offset parameter name #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…offset parameter name Update the parameter name for the longitudinal offset distance used for collision check in the autonomous emergency braking control module. The parameter name has been changed from "longitudinal_offset" to "longitudinal_offset_margin" to better reflect its purpose. Refactor the code to use the new parameter name consistently throughout the module. This includes updating the README.md file, the configuration file, the node.hpp file, and the node.cpp file. This change ensures that the parameter name accurately represents its functionality and improves code readability. Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
requested review from
danielsanchezaran,
soblin,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9463 +/- ##
==========================================
- Coverage 29.08% 29.08% -0.01%
==========================================
Files 1438 1439 +1
Lines 108433 108462 +29
Branches 41511 41515 +4
==========================================
+ Hits 31535 31541 +6
- Misses 73845 73869 +24
+ Partials 3053 3052 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This minor refactor PR includes
longitudinal_offsettolongitudinal_offset_marginlimit_imu_path_lengthmin_moving_velocity_thtoMIN_MOVING_VELOCITY_THRESHOLDand moved to namespaceIMU_PATH_COLOR,MPC_PATH_COLOR)base_to_front_offsettobase_link_to_front_offsetThis PR should be merged with the PR
Related links
Parent Issue:
How was this PR tested?
run planning_simulator
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.