Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_processing_time_checker): add a trigger to choice whether to output metrics to log folder #9479

Merged

Conversation

xtk8532704
Copy link
Contributor

@xtk8532704 xtk8532704 commented Nov 26, 2024

Description

Add a bool parameter output_metrics, if it's true, the autoware_processing_time_checker node writes the statics of the processing_time measured during its lifetime to <ros2_logging_directory>/autoware_metrics/<node_name>-<time_stamp>.json when shut down.

This feature will be used to collect and analyze test results in real vehicle tests and evaluator tests.

Related links

Launch side PR: autowarefoundation/autoware_launch#1255

How was this PR tested?

Psim with output_metrics=true:

$ cat /home/temkeikem/.ros/log/autoware_metrics/autoware_processing_time_checker-2024-11-27-01-42-15.json 
{
    "avoidance_by_lane_change/count": 235,
    "avoidance_by_lane_change/description": "processing time of avoidance_by_lane_change[ms]",
    "avoidance_by_lane_change/max": 2.492,
    "avoidance_by_lane_change/mean": 0.1548723404255319,
    "avoidance_by_lane_change/min": 0.0,
    # ignore many outputs.
    "walkway/count": 225,
    "walkway/description": "processing time of walkway[ms]",
    "walkway/max": 0.085,
    "walkway/mean": 0.033093333333333336,
    "walkway/min": 0.018
}

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xtk8532704 xtk8532704 force-pushed the xtk/metric-log-timer-checker branch from 7a20e4b to 9d9dc86 Compare November 27, 2024 04:55
@github-actions github-actions bot removed component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Nov 27, 2024
@xtk8532704 xtk8532704 marked this pull request as ready for review November 27, 2024 04:56
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (12a86f6) to head (862cca1).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ssing_time_checker/src/processing_time_checker.cpp 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9479      +/-   ##
==========================================
- Coverage   29.42%   29.41%   -0.01%     
==========================================
  Files        1439     1439              
  Lines      108512   108547      +35     
  Branches    41488    41496       +8     
==========================================
  Hits        31934    31934              
- Misses      73355    73390      +35     
  Partials     3223     3223              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.42% <ø> (ø) Carriedforward from 9d9dc86

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xtk8532704 <[email protected]>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xtk8532704 xtk8532704 merged commit 35048a9 into autowarefoundation:main Nov 27, 2024
31 of 32 checks passed
@xtk8532704 xtk8532704 deleted the xtk/metric-log-timer-checker branch November 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants