-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_processing_time_checker): add a trigger to choice whether to output metrics to log folder #9479
feat(autoware_processing_time_checker): add a trigger to choice whether to output metrics to log folder #9479
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
e971bad
to
7a20e4b
Compare
Signed-off-by: xtk8532704 <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
7a20e4b
to
9d9dc86
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9479 +/- ##
==========================================
- Coverage 29.42% 29.41% -0.01%
==========================================
Files 1439 1439
Lines 108512 108547 +35
Branches 41488 41496 +8
==========================================
Hits 31934 31934
- Misses 73355 73390 +35
Partials 3223 3223
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: xtk8532704 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a bool parameter
output_metrics
, if it's true, the autoware_processing_time_checker node writes the statics of the processing_time measured during its lifetime to<ros2_logging_directory>/autoware_metrics/<node_name>-<time_stamp>.json
when shut down.This feature will be used to collect and analyze test results in real vehicle tests and evaluator tests.
Related links
Launch side PR: autowarefoundation/autoware_launch#1255
How was this PR tested?
Psim with
output_metrics=true
:Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.