Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_lidar_transfusion): non-maximum suppression target decision logic #9612

Conversation

technolojin
Copy link
Contributor

Description

Implement same fix of PR #9595

Related links

  1. fix non-maximum suppression target decision logic
    Before: If both of the object class are in the target label, caluclate IoU. If not, check distance and calculate IoU if the distance is less than a threshold.
    After: If the label pair is not the same and one of them is pedestrian, do not suppress. Then, check distance and calcuclate IoU only if the distance is within a threshold.

  2. optimize non-maximum suppression search range
    Keep the squared value of the distance threshold.

  3. remove NMS type
    Since there is no other NMS option, remove the logic and parameter to select NMS type.

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Dec 11, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 11, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin
Copy link
Contributor Author

@amadeuszsz
Can you test and review this PR?
I do not have the model.

@technolojin technolojin marked this pull request as ready for review December 11, 2024 06:23
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.57%. Comparing base (01944ef) to head (812f133).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...fusion/lib/postprocess/non_maximum_suppression.cpp 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9612      +/-   ##
==========================================
- Coverage   29.57%   29.57%   -0.01%     
==========================================
  Files        1442     1443       +1     
  Lines      108498   108501       +3     
  Branches    41396    41392       -4     
==========================================
- Hits        32092    32088       -4     
- Misses      73285    73295      +10     
+ Partials     3121     3118       -3     
Flag Coverage Δ *Carryforward flag
differential 4.38% <87.50%> (?)
total 29.56% <ø> (-0.01%) ⬇️ Carriedforward from 01944ef

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@technolojin technolojin merged commit da5284c into autowarefoundation:main Dec 11, 2024
46 of 47 checks passed
@technolojin technolojin deleted the fix/transfusion/nms-target-fix branch December 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants