chore(crosswalk): port the same direction ignore block #9983
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jan 20, 2025 in 55s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.16 (5.22 -> 5.37)
- Improving Code Health: 6 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
✅ Improving Code Health:
- Lines of Code in a Single File scene_crosswalk.cpp 🔥
- Overall Code Complexity scene_crosswalk.cpp 🔥
- Deep, Nested Complexity scene_crosswalk.cpp: CrosswalkModule::checkStopForCrosswalkUsers 🔥
- Complex Method scene_crosswalk.cpp: CrosswalkModule::checkStopForCrosswalkUsers 🔥
- Complex Conditional scene_crosswalk.cpp: CrosswalkModule::checkStopForCrosswalkUsers 🔥
- Bumpy Road Ahead scene_crosswalk.cpp: CrosswalkModule::checkStopForCrosswalkUsers 🔥
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1089 to 1074, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
CrosswalkModule::checkStopForCrosswalkUsers decreases in cyclomatic complexity from 16 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
CrosswalkModule::checkStopForCrosswalkUsers no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
CrosswalkModule::checkStopForCrosswalkUsers is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.97 to 5.81, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Deep, Nested Complexity
CrosswalkModule::checkStopForCrosswalkUsers is no longer above the threshold for nested complexity depth. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Loading