Skip to content
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 5, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 13 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method sampling_planner_module.cpp: SamplingPlannerModule::plan
  • Complex Method sampling_planner_module.cpp: SamplingPlannerModule::generateExpandDrivableLanes
  • Overall Code Complexity sampling_planner_module.cpp
  • Complex Method sampling_planner_module.cpp: SamplingPlannerModule::prepareSamplingParameters
  • Large Method sampling_planner_module.cpp: SamplingPlannerModule::isReferencePathSafe
  • Complex Method sampling_planner_module.cpp: SamplingPlannerModule::updateDebugMarkers
  • Deep, Nested Complexity sampling_planner_module.cpp: SamplingPlannerModule::plan
  • Deep, Nested Complexity sampling_planner_module.cpp: SamplingPlannerModule::generateExpandDrivableLanes
  • Deep, Nested Complexity sampling_planner_module.cpp: SamplingPlannerModule::prepareSamplingParameters
  • Bumpy Road Ahead sampling_planner_module.cpp: SamplingPlannerModule::generateExpandDrivableLanes
  • Bumpy Road Ahead sampling_planner_module.cpp: SamplingPlannerModule::plan
  • Bumpy Road Ahead sampling_planner_module.cpp: SamplingPlannerModule::updateDebugMarkers
  • Bumpy Road Ahead sampling_planner_module.cpp: SamplingPlannerModule::prepareSamplingParameters

Annotations

Check warning on line 672 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

SamplingPlannerModule::plan has a cyclomatic complexity of 26, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 918 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

SamplingPlannerModule::generateExpandDrivableLanes has a cyclomatic complexity of 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 976 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

SamplingPlannerModule::prepareSamplingParameters has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 746 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

SamplingPlannerModule::updateDebugMarkers has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 277 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

SamplingPlannerModule::isReferencePathSafe has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 918 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

SamplingPlannerModule::generateExpandDrivableLanes has 4 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 672 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

SamplingPlannerModule::plan has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 746 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

SamplingPlannerModule::updateDebugMarkers has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 976 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

SamplingPlannerModule::prepareSamplingParameters has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 6.73 across 15 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 672 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

SamplingPlannerModule::plan has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 918 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

SamplingPlannerModule::generateExpandDrivableLanes has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 976 in planning/behavior_path_sampling_planner_module/src/sampling_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

SamplingPlannerModule::prepareSamplingParameters has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.